Bug 390041 - Use cairo instead of gdk_draw_pixbuf()
Summary: Use cairo instead of gdk_draw_pixbuf()
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-09-20 13:20 EDT by Anatoly Spektor CLA
Modified: 2012-10-24 14:38 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-09-20 13:20:18 EDT 
What I did in the patch below:

gdk_draw_pixbuf() was already set us dynamic, however casts was causing problem when compiling against GTK+ 3, so I removed  casts.


I have also implemented Cairo alternative in  2 classes, basing on GTK+ docs.

Patch is available here:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gdk_draw_pixbuff
Comment 1 Silenio Quarti CLA 2012-10-24 12:58:52 EDT 
Change in GC is not necessary. Code path is already protected by USE_CAIRO. 

Changes in OS.java and os.java have been made already in another patch.

Fixed
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9fc8665c72017ac9e9a5c41d2c7268083a59fe01