Bug 389842 - TaskAttribute#setValues should not accept null
Summary: TaskAttribute#setValues should not accept null
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 3.9   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2012-09-18 16:28 EDT by Benjamin Muskalla CLA
Modified: 2012-09-23 17:23 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2012-09-18 16:28:32 EDT 
In order to preserve symmetry, setValues on TaskAttribute should not accept null. setValue refuses null and by contract, getValue should never return null. But passing null as part of setValues is working even though it should not.
Comment 1 Benjamin Muskalla CLA 2012-09-18 16:52:46 EDT 
Review up at https://git.eclipse.org/r/7809
Comment 2 Steffen Pingel CLA 2012-09-23 17:18:17 EDT 
Thanks for the contribution! The proposed change looks great.
Comment 3 Steffen Pingel CLA 2012-09-23 17:23:28 EDT 
The change was merged.