Community
Participate
Working Groups
The toolbars seem to get updated too often when opening multiple editors (flashing chevron). We might be computing item size too many times (once when initially creating the item and again on the resize event).
There seemed to be updates triggered by multiple separate calls: tool item creation, setImage, setText, and a couple of others. This showed up near the top of the hotspots list in a sampling profile run of opening/closing a single Java editor multiple times.
The flashing of toolbars occured on Win32 only and was a direct result of having to flush any outstanding paints to a toolbar before measuring its new size. This code has been there since 2001 (no one here remembered the history). Upon further investigation, we determined that it might not be needed on Windows 7. But all of this became a moot point as we changed our approach to drawing CTabFolders to batch all the redraw and layout requests. Fixed in master (and will be potentially put into 4.2.2 via Bug 389773 after running the code for a while).
