Description Michael Vorburger 2012-09-04 19:17:09 EDT

When things go wrong in DataBinding, they are hard to catch.

I do understand that the basic approach of binding makes the usual propagation of exceptions up the calling stack difficult (useless, who would catch it?), and that the ValidationStatus (IStatus) should be checked by e.g. a UI, but would argue that simply also providing more logging exceptions as error when caught inside Data Binding couldn't hurt and would help in development.

More specifically, I would suggest logging the Exception caught in org.eclipse.core.databinding.UpdateValueStrategy#doSet(), and related similar methods such as UpdateListStrategy's doAdd() & doMove() & doReplace() as well as UpdateSetStrategy's doAdd() & doRemove().

Logging "Framework" chosen probably wouldn't be slfj4j or similar API, but DataBinding's own Policy.getLog().log(new Status(IStatus.ERROR, Policy.JFACE_DATABINDING, 0, "..." / e.getMessage()?, e)); as elsewhere in the DataBinding codebase.

If you think this idea is of interest and prefer getting a concrete patch proposal / GitHub pull request instead of the textual proposal above, please let me know and I'll contribute one.