Bug 38782 - TreeViewer add calls a refresh
Summary: TreeViewer add calls a refresh
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-11 11:47 EDT by Tod Creasey CLA
Modified: 2005-05-10 14:55 EDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (4.95 KB, patch)
2003-06-11 14:37 EDT, Tod Creasey CLA
no flags Details | Diff
Updated patch (89.36 KB, patch)
2003-06-12 09:49 EDT, Tod Creasey CLA
no flags Details | Diff
log n patch (4.50 KB, patch)
2003-06-13 14:30 EDT, Tod Creasey CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2003-06-11 11:47:53 EDT
Our implementation of TreeViewer.add is naive and can all a refresh of the 
entire tree. It should be more like TableViewer.
Comment 1 Tod Creasey CLA 2003-06-11 14:37:40 EDT
Created attachment 5165 [details]
Proposed patch

Patch to be reviewed by Nick
Comment 2 Tod Creasey CLA 2003-06-11 14:38:26 EDT
I have a patch for this (see attached) but I would to review with Nick before 
releasing it as it is a significant simplification.
Comment 3 Tod Creasey CLA 2003-06-12 09:49:36 EDT
Created attachment 5173 [details]
Updated patch

Patch with correction for ordering of creation
Comment 4 Tod Creasey CLA 2003-06-13 14:30:01 EDT
Created attachment 5190 [details]
log n patch

New patch using algorithm similar to TableViewer
Comment 5 Tod Creasey CLA 2003-06-24 09:52:02 EDT
Fixed in build >20030624
Comment 6 Tod Creasey CLA 2003-06-25 10:05:43 EDT
There are some problem arising with the JFace AllTests suite. Reopening until 
these are dealt with.
Comment 7 Tod Creasey CLA 2003-07-21 12:02:36 EDT
Fixed in M2.
Comment 8 Tod Creasey CLA 2005-05-10 14:55:46 EDT
Marking closed