Bug 387175 - Java package incorrectly decorated in flat representation (from changes in subdirectories)
Summary: Java package incorrectly decorated in flat representation (from changes in su...
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 318822 347552 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-14 04:23 EDT by Nobody - feel free to take it CLA
Modified: 2014-04-19 09:53 EDT (History)
5 users (show)

See Also:


Attachments
Screenshot (164.77 KB, image/jpeg)
2012-08-14 04:23 EDT, Nobody - feel free to take it CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2012-08-14 04:23:05 EDT
While using the default flat package representation in the Package Explorer view you get some packages with the ">" decorator even though there's no changed file. This generally will happen if the package name is A and there are changes in A.B but not in A. Will attach a screenshot. Meanwhile in the hierarchical representation it may make sense in this case it seems erratic behavior. 

EGit 2.0.0.201206130900-r on 4.2 release.
Comment 1 Nobody - feel free to take it CLA 2012-08-14 04:23:39 EDT
Created attachment 219840 [details]
Screenshot
Comment 2 Robin Stocker CLA 2012-08-30 16:52:29 EDT
The CVS provider does it correctly. So it's possible, we just need to find out how.
Comment 3 Robin Stocker CLA 2013-03-18 19:23:56 EDT
*** Bug 347552 has been marked as a duplicate of this bug. ***
Comment 4 Robin Stocker CLA 2013-03-18 19:26:47 EDT
Dani/Markus: Any hints on how to fix this, which API we could use?
Comment 5 Markus Keller CLA 2013-03-19 07:59:11 EDT
See org.eclipse.team.internal.ccvs.ui.CVSLightweightDecorator#decorate(Object, SynchronizationStateTester) and callers. The "meat" of the implementation is that tester.getState(..) ends up in org.eclipse.jdt.internal.ui.packageview.HierarchicalDecorationContext.HierarchicalSynchronizationStateTester, which knows about the Package Explorer's presentation and can adjust the element to a JavaElementResourceMapping.

The original JDT UI fix was bug 128990.
Comment 6 Robin Stocker CLA 2013-05-18 15:51:58 EDT
*** Bug 318822 has been marked as a duplicate of this bug. ***