Bug 128990 - CVS label decorations should be recursive, when using tree view in package explorer
Summary: CVS label decorations should be recursive, when using tree view in package ex...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 128833 129774 132983 135385 (view as bug list)
Depends on: 131969
Blocks:
  Show dependency tree
 
Reported: 2006-02-22 11:11 EST by Tobias Vogele CLA
Modified: 2006-12-23 13:06 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Vogele CLA 2006-02-22 11:11:15 EST 
When using the the tree view in the package explorer, package com.foo.bar is shown as a child of package com.foo. 
Therefore the CVS label decorations of package com.foo should mark it as dirty even if only com.foo.bar contains dirty files. So the label decoration should be recursive, as they were before Version 3.2 M5.

This would make it a lot easier to find edited files for commit, when the tree nodes are collapsed. 

IHMO the CVS actions should also be recursive, when using the tree view. However, I understand that this can be dangerous when committing/replacing files unintentionally.
Comment 1 Markus Keller CLA 2006-02-22 11:29:12 EST 
I agree. Tobias, would it be possible to change the behavior in the package explorer, depending on the package presentation?
Comment 2 Michael Valenta CLA 2006-03-06 10:12:34 EST 
*** Bug 129774 has been marked as a duplicate of this bug. ***
Comment 3 Markus Keller CLA 2006-03-23 07:26:55 EST 
*** Bug 132983 has been marked as a duplicate of this bug. ***
Comment 4 Tobias Widmer CLA 2006-03-29 03:15:57 EST 
Marking as duplicate of bug 131969

See other bug for reason.

*** This bug has been marked as a duplicate of 131969 ***
Comment 5 Martin Aeschlimann CLA 2006-04-11 06:44:12 EDT 
reopen
Comment 6 Martin Aeschlimann CLA 2006-04-11 06:45:13 EDT 
*** Bug 128833 has been marked as a duplicate of this bug. ***
Comment 7 Martin Aeschlimann CLA 2006-04-11 06:48:58 EDT 
*** Bug 135385 has been marked as a duplicate of this bug. ***
Comment 8 Martin Aeschlimann CLA 2006-04-11 06:57:29 EDT 
fixed > 20060411

Package Explorer/Packages view now uses a decoration context to modify the SynchronizationStateTester when in hierarchical mode.

Note that this is a fix just for the team decorators. I'll file a request to generalize this so that also other decorators can be fixed.
In general, actions and decorators always work on the model structure, not on the view structure. E.g. a commit on a hierarchical package still only releases the compilation units directly inside, but no subpackages (see bug 131969)