Community
Participate
Working Groups
It is possible that the code that propagates the icon from the shell to a dialog child may not be needed. The gtk doc for gtk_window_set_icon_list () http://developer.gnome.org/gtk/2.24/GtkWindow.html#gtk-window-set-icon-list says that "transient windows will inherit their icon from their transient parent". So for example this code in MessageBox.open(): if (parentHandle != 0) { int /*long*/ pixbufs = OS.gtk_window_get_icon_list (parentHandle); if (pixbufs != 0) { OS.gtk_window_set_icon_list (handle, pixbufs); OS.g_list_free (pixbufs); } } might not be needed (need to test this to verify). (SSQ thinks it might have been needed in some previous version of GTK, so we would still have to do it before the current version of gtk).
New Gerrit change created: https://git.eclipse.org/r/127433
Gerrit change https://git.eclipse.org/r/127433 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f241cc874342ce675ac143bbdd287a607962252e
(In reply to Eclipse Genie from comment #2) > Gerrit change https://git.eclipse.org/r/127433 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=f241cc874342ce675ac143bbdd287a607962252e In master now.
Verified in I20180821-2000.