Bug 386054 - Unnecessary code in dialogs?
Summary: Unnecessary code in dialogs?
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.9 M3   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2012-07-26 10:44 EDT by Carolyn MacLeod CLA
Modified: 2018-08-23 08:27 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2012-07-26 10:44:21 EDT
It is possible that the code that propagates the icon from the shell to a dialog child may not be needed. The gtk doc for gtk_window_set_icon_list ()
http://developer.gnome.org/gtk/2.24/GtkWindow.html#gtk-window-set-icon-list
says that "transient windows will inherit their icon from their transient parent". So for example this code in MessageBox.open():

if (parentHandle != 0) {
	int /*long*/ pixbufs = OS.gtk_window_get_icon_list (parentHandle);
	if (pixbufs != 0) {
		OS.gtk_window_set_icon_list (handle, pixbufs);
		OS.g_list_free (pixbufs);
	}
}

might not be needed (need to test this to verify). (SSQ thinks it might have been needed in some previous version of GTK, so we would still have to do it before the current version of gtk).
Comment 1 Eclipse Genie CLA 2018-08-14 16:58:53 EDT
New Gerrit change created: https://git.eclipse.org/r/127433
Comment 3 Eric Williams CLA 2018-08-15 14:57:05 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/127433 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=f241cc874342ce675ac143bbdd287a607962252e

In master now.
Comment 4 Eric Williams CLA 2018-08-23 08:27:02 EDT
Verified in I20180821-2000.