Bug 385987 - Hidden tabs' filenames should be bolded in "Show List" drop-down of tabbed editor view.
Summary: Hidden tabs' filenames should be bolded in "Show List" drop-down of tabbed ed...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal with 4 votes (vote)
Target Milestone: 4.4 M1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard: patch
Keywords: helpwanted
: 394104 408153 (view as bug list)
Depends on:
Blocks: 411503
  Show dependency tree
 
Reported: 2012-07-25 17:08 EDT by Michael Mangino CLA
Modified: 2013-08-12 08:53 EDT (History)
11 users (show)

See Also:


Attachments
"Show List" screenshot in Indigo. Shows correct bolding of hidden tabs. (76.55 KB, image/jpeg)
2012-07-25 17:10 EDT, Michael Mangino CLA
no flags Details
"Show List" screenshot in Juno. Shows non-bolding of hidden tabs. (101.56 KB, image/jpeg)
2012-07-25 17:11 EDT, Michael Mangino CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mangino CLA 2012-07-25 17:08:22 EDT
Build Identifier: Version: Juno Release Build id: 20120614-1722

When so many files are being edited that all tabs cannot be shown, a double-arrow icon appears to the right of the right-most tab, along with a number indicating the number of hidden tabs. When clicking this icon, a drop-down is displayed showing all files open in that tab group. Prior to Juno, the hidden tabs' filenames appeared in bolded text in this list. However, in Juno, the hidden tabs' filenames are not bolded.

Having the hidden entries bolded is a very nice usability feature because it allows the user to easily see the groups of hidden and visible files that are open.

Reproducible: Always

Steps to Reproduce:
1. Open enough files that some of their tabs become hidden.
2. Click on the "Show List" double-arrow icon to the right of the right-most visible file tab.
3. Note that the hidden files' names are not bolded.
Comment 1 Michael Mangino CLA 2012-07-25 17:10:26 EDT
Created attachment 219188 [details]
"Show List" screenshot in Indigo. Shows correct bolding of hidden tabs.
Comment 2 Michael Mangino CLA 2012-07-25 17:11:00 EDT
Created attachment 219189 [details]
"Show List" screenshot in Juno. Shows non-bolding of hidden tabs.
Comment 3 Mauro Molinari CLA 2012-10-28 14:00:39 EDT
I agree with this request and I also opened bug #393002 to provide an option to restore the MRU editor tabs visibility policy of Eclipse 3.x!
Comment 4 Paul Webster CLA 2012-11-12 10:33:43 EST
*** Bug 394104 has been marked as a duplicate of this bug. ***
Comment 5 Dave CLA 2012-12-03 16:13:31 EST
This problem has been bugging (no pun intended) me ever since I switched to Juno. It's especially annoying if the files either have identical names or begin with the same words: SomeJavaClassModel.java and SomeJavaClassModelEditor.java and the tab only shows "SomeJavaClass..." while the expanded list does not tell me which one I'm looking at and which one's hidden.
Comment 6 Markus Keller CLA 2013-05-17 11:22:06 EDT
*** Bug 408153 has been marked as a duplicate of this bug. ***
Comment 7 Leonid Ripeynih CLA 2013-05-21 14:07:42 EDT
Here is proposed fix

https://git.eclipse.org/r/13031
Please, review.
Comment 9 Dani Megert CLA 2013-06-25 08:19:51 EDT
The bundle version was not updated in both bundles.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d2800a3e2efc4b9ed32933efa6a569862a8ab49c
Comment 10 Eric Moffatt CLA 2013-08-07 10:44:39 EDT
Verified in 4.4.0.I20130806-2000.
Comment 11 Dani Megert CLA 2013-08-12 08:53:14 EDT
Verified in 4.4 M1.

We should revisit the usage of bold for hidden items though, see bug 70982.