Bug 385697 - "Data" menu is missing on top menu
Summary: "Data" menu is missing on top menu
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 366528
Blocks:
  Show dependency tree
 
Reported: 2012-07-23 04:29 EDT by Hao Zhou CLA
Modified: 2018-09-26 16:42 EDT (History)
5 users (show)

See Also:


Attachments
screenshot (96.85 KB, image/png)
2012-07-23 04:30 EDT, Hao Zhou CLA
no flags Details
log (97.61 KB, text/plain)
2012-07-23 21:32 EDT, Hao Zhou CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hao Zhou CLA 2012-07-23 04:29:35 EDT
Build Identifier: Version: 4.2.0 Build id: I20120608-1400

1,new report project
2,new a rptdesign, new datasource and data set

check top menu
Can't find "data" menu

Reproducible: Always
Comment 1 Hao Zhou CLA 2012-07-23 04:30:41 EDT
Created attachment 219039 [details]
screenshot
Comment 2 Paul Webster CLA 2012-07-23 10:09:57 EDT
Did you start with Eclipse from http://www.eclipse.org/downloads/ ?  What filename did you unzip to install eclipse?  Did you install any other plugins?

Is there anything in your error log that you can attach?  <workspace>/.metadata/.log

Also, if you leave the editor open an switch perspectives and back, does the menu appear?

PW
Comment 3 Hao Zhou CLA 2012-07-23 21:31:35 EDT
(In reply to comment #2)
> Did you start with Eclipse from http://www.eclipse.org/downloads/ ?  What
> filename did you unzip to install eclipse?  Did you install any other plugins?
> 
> Is there anything in your error log that you can attach? 
> <workspace>/.metadata/.log
> 
> Also, if you leave the editor open an switch perspectives and back, does the
> menu appear?
> 
> PW

I use "birt-report-designer-all-in-one-4_2_0-20120613.zip" from Actuate, didn't install other plugins.
"Data" menu don't appear after switch perspectives.
Comment 4 Hao Zhou CLA 2012-07-23 21:32:15 EDT
Created attachment 219089 [details]
log
Comment 5 Paul Webster CLA 2012-07-23 21:39:35 EDT
Please provide a URL to the download page, Actuate is not the Eclipse Foundation.

PW
Comment 7 Xiaoying Gu CLA 2012-07-23 22:55:14 EDT
In the WorkbenchMenuService class of e4, it doesn't implement the method populateContributionManager, so we can't get the menu items from the plugin extension points. 

And I look at the eclipse source code, the eclipse self also has the same problem.

I don't know why e4 doesn't implement the method populateContributionManager, and I don't find any relative articles or bugs.
Comment 8 Paul Webster CLA 2012-07-24 08:29:41 EDT
(In reply to comment #7)
> In the WorkbenchMenuService class of e4, it doesn't implement the method
> populateContributionManager, so we can't get the menu items from the plugin
> extension points. 

How is the Data menu being contributed?  The standard use of org.eclipse.ui.menus should just work, as should even an actionSet.

See also bug 366528

PW
Comment 9 Chen Chao CLA 2012-10-16 02:13:14 EDT
(In reply to comment #8)
> (In reply to comment #7)
> > In the WorkbenchMenuService class of e4, it doesn't implement the method
> > populateContributionManager, so we can't get the menu items from the plugin
> > extension points. 
> 
> How is the Data menu being contributed?  The standard use of
> org.eclipse.ui.menus should just work, as should even an actionSet.
> 
> See also bug 366528
> 
> PW

// Data Menu
MenuManager dataMenu = new MenuManager( Messages.getString( "DesignerActionBarContributor.menu.data" ), M_DATA ); //$NON-NLS-1$

// the data actions are now registered through eclipse menu extensions
IMenuService menuService = (IMenuService) PlatformUI.getWorkbench( )
				.getService( IMenuService.class );
		menuService.populateContributionManager( dataMenu, "menu:birtData" ); //$NON-NLS-1$
		menubar.insertAfter( M_ELEMENT, dataMenu );
Comment 10 Chen Chao CLA 2012-10-16 02:18:39 EDT
(In reply to comment #8)

(In reply to comment #8)
> (In reply to comment #7)
> > In the WorkbenchMenuService class of e4, it doesn't implement the method
> > populateContributionManager, so we can't get the menu items from the plugin
> > extension points. 
> 
> How is the Data menu being contributed?  The standard use of
> org.eclipse.ui.menus should just work, as should even an actionSet.
> 
> See also bug 366528
> 
> PW

We custom a menu locationURI="menu:birtData", then use the org.eclipse.ui.menus extension point to registry the menuitem. and use IMenuService.populateContributionManager to gather the registered menuitems.


I know the e4 application model can implement this function, but we don't want to depend the e4 framework.
Comment 11 Paul Webster CLA 2012-10-16 09:10:26 EDT
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> 		menubar.insertAfter( M_ELEMENT, dataMenu );

Where did menubar come from?

PW
Comment 12 Paul Webster CLA 2012-10-16 09:11:37 EDT
(In reply to comment #10)
> We custom a menu locationURI="menu:birtData", then use the
> org.eclipse.ui.menus extension point to registry the menuitem. and use
> IMenuService.populateContributionManager to gather the registered menuitems.


We still plan to support IMenuService.populateContributionManager(*) so that will still work without looking to any new Eclipse4 functionality.  It's just not fixed yet.


Bug 366528 - [Compatibility] Implement IMenuService#populateContributionManager(*)

PW
Comment 13 Chen Chao CLA 2013-01-18 02:49:32 EST
*** Bug 398058 has been marked as a duplicate of this bug. ***
Comment 14 Eclipse Genie CLA 2018-09-26 16:41:46 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 15 Lars Vogel CLA 2018-09-26 16:42:40 EDT
i think this is fixed.