Bug 385347 - Omit use of deprecated GTK_WIDGET_UNSET_FLAGS
Summary: Omit use of deprecated GTK_WIDGET_UNSET_FLAGS
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-07-17 15:42 EDT by Anatoly Spektor CLA
Modified: 2013-05-24 09:34 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-07-17 15:42:00 EDT 
Build Identifier: I20120503-1800

This patch omits use of deprecated constant GTK_WIDGET_UNSET_FLAGS and uses new methods instead:

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=c03b678fc13122f23aea447ac9d185e0bf5f5f47

Reproducible: Always
Comment 2 Anatoly Spektor CLA 2012-08-07 14:20:44 EDT 
I have added helper function and omitted implementation of GTK_HAS_FOCUS.

Please review this patch:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_widget_unset_flags&id=bc551e2d95f836a4a16b35255ead09efc7b47b54
Comment 3 Silenio Quarti CLA 2012-08-08 10:26:51 EDT 
Fixed

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=27e4e4382fd0d1ea5096b74264f64b5ca0207625

Note that the implementation of the helpers was wrong when calling with false. And I also found code that did not go through the helper functions.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=37911e0ffd8884382e7030a0b8c6d0f4e7752bc6
Comment 4 Anatoly Spektor CLA 2012-08-08 10:29:03 EDT 
Yeah I didn't notice that, Thanks for fixing Silenio!