Bug 385309 - Omit use of deprecated GTK_WIDGET_FLAGS
Summary: Omit use of deprecated GTK_WIDGET_FLAGS
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-07-17 09:57 EDT by Anatoly Spektor CLA
Modified: 2013-05-24 09:34 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-07-17 09:57:15 EDT 
Build Identifier: I20120503-1800

This patch omits use of GTK_WIDGET_FLAGS:

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=b468e9239bca7d603290b2d0bfc1e6125b9458ad

Reproducible: Always
Comment 1 Silenio Quarti CLA 2012-08-01 14:05:35 EDT 
Please add a three helper functions (the same way I added for bug#384651).
Comment 2 Anatoly Spektor CLA 2012-08-02 16:42:43 EDT 
What I did:

1. Fixed formatting
2. Added 4 Helper function 
       - gtk_widget_get_visible
       - gtk_widget_get_can_default
       - gtk_widget_get_realized
       - gtk_widget_get_has_window
3. Put my previous implementation in helper functions and replaced  every implementation with suitable helper function.

Patch can be found here:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_widget_flags_
Comment 3 Silenio Quarti CLA 2012-08-03 11:20:28 EDT 
Found some problems with patch:

- In Control.moveHandle(), gtk_widget_get_visible() has to be called before the the to GTK_WIDGET_UNSET_FLAGS() otherewise gtk_widget_get_visible() equals false always.

- In ProgressBar.updateBar, reversed test.

- In Shell, I am not sure it is the same, but we should use logical OR instead of bitwise OR.


Fixed problems and pushed to eclipse.org

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5983c24ed5237e3fc3d1e8e4c23d3ce4ce153bac
Comment 4 Anatoly Spektor CLA 2012-08-03 11:22:10 EDT 
Thanks for fixing problems.