385070 – Use gtk_widget_has_focus instead of deprecated GTK_WIDGET_HAS_FOCUS

Bug 385070 - Use gtk_widget_has_focus instead of deprecated GTK_WIDGET_HAS_FOCUS

Summary: Use gtk_widget_has_focus instead of deprecated GTK_WIDGET_HAS_FOCUS

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.2
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.3 M2
Assignee:	Arun Thondapu
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	340067
	Show dependency tree

Reported:	2012-07-13 11:57 EDT by Anatoly Spektor
Modified:	2013-05-24 09:34 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anatoly Spektor

2012-07-13 11:57:09 EDT

Build Identifier: I20120503-1800

This patch omits use of deprecated method GTK_WIDGET_HAS_FOCUS and uses gtk_widget_has_focus() instead:

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=9a8e58ef3c28f47b9fa688d8029315e0ae2501d2

Reproducible: Always

Comment 1 Silenio Quarti

2012-08-01 14:03:09 EDT

Please add a Widget.gtk_widget_has_focus() helper function (the same way I added for bug#384651). Fix formatting too.

Comment 2 Anatoly Spektor

2012-08-01 16:33:44 EDT

Added helper as you asked:

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=9bb1e4d4ad7039f53c4b322b6d5a78da6c13d023

Comment 3 Anatoly Spektor

2012-08-01 16:57:26 EDT

(In reply to comment #2)
> Added helper as you asked:
> 
> http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.
> git;a=commit;h=9bb1e4d4ad7039f53c4b322b6d5a78da6c13d023

There is small issue with os_custom.h in the patch I posted. I will post revised version shortly.

Regards,

Anatoly

Comment 4 Anatoly Spektor

2012-08-02 10:41:20 EDT

Here is revised patch with fixed formatting and helper:

http://fedorapeople.org/cgit/aspektor/public_git/eclipse.platform.swt.git/commit/?h=gtk_widget_has_focus&id=8b24aa572a642d71614f887189c3f4849201abcc

Comment 5 Arun Thondapu

2012-08-06 04:07:17 EDT

Thanks for the patch!

Pushed to eclipse.org

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2c810dc09ebe584d949d1446e7fe61dd64fa3e80