Bug 384771 - when opening a file that is already open, activate existing compare editor instead of opening another one
Summary: when opening a file that is already open, activate existing compare editor in...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 2.6   Edit
Assignee: Nicholas Folk CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2012-07-10 15:42 EDT by Sam Davis CLA
Modified: 2015-01-23 13:09 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2012-07-10 15:42:46 EDT 
* open a review
* open a file from a patch set
* switch back to the review
* double click on the same file again
* a second compare editor is opened on the same file

It would be better just to activate the existing compare editor as this is probably a common navigation pattern. When looking at multiple files its easy to end up with a large number of redundant compare editors.
Comment 1 Steffen Pingel CLA 2012-08-06 10:43:41 EDT 
I agree that this would be helpful.
Comment 2 Kyle Malong CLA 2012-11-21 13:54:07 EST 
I have a review up - https://git.eclipse.org/r/#/c/8790/
Comment 3 Miles Parker CLA 2014-09-24 16:14:05 EDT 
See my comment on this review. @Kyle, do you want to follow-up on this?
Comment 4 Sam Davis CLA 2015-01-23 13:09:35 EST 
Fixed with https://git.eclipse.org/r/#/c/39904/. Thanks Nicholas!