Bug 384685 - consume Apache Lucene 3.x
Summary: consume Apache Lucene 3.x
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.9   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2012-07-10 02:35 EDT by Krzysztof Daniel CLA
Modified: 2012-10-16 04:25 EDT (History)
3 users (show)

See Also:
krzysztof.daniel: review? (greensopinion)

Attachments
A patch used in Fedora (4.49 KB, patch)
2012-07-10 02:35 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2012-07-10 02:35:16 EDT 
Created attachment 218481 [details]
A patch used in Fedora

Lucene 3.x adoption is on the horizon.
https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced;list_id=2245181;short_desc=lucene%203;short_desc_type=allwordssubstr

I've attached a patch used in Fedora that makes mylyn compile with Lucene 3+.
Comment 1 Steffen Pingel CLA 2012-07-10 12:02:14 EDT 
Thanks for the patch. We'll can consider that for 3.9 but will need to update the target environments and file a CQ to consume the newer release of Lucene. Note that the newer Lucene release sometime interacts badly with the platform: bug 382574.
Comment 2 Steffen Pingel CLA 2012-09-15 21:49:11 EDT 
Would you be able to push the patch as a Gerrit review? It's easier for us to validate and consume contributions that way.
Comment 3 Krzysztof Daniel CLA 2012-09-17 08:13:59 EDT 
Here you are https://git.eclipse.org/r/7786
Comment 4 Steffen Pingel CLA 2012-09-23 17:13:25 EDT 
Thanks! Did you check if the code changes are also compatible with Lucene 2.9.1? It looks like a change that we could make regardless of the Lucene version that is consumed.
Comment 5 Krzysztof Daniel CLA 2012-09-24 03:39:46 EDT 
Hi Steffen,

Fedora ships lucene 3.x in version >= 18, and 2.x in < 18. Eclipse Mylyn 3.8.1 with this patch has been built for both Fedora versions and pushed to users about a month ago. Nobody complained https://admin.fedoraproject.org/updates/FEDORA-2012-12348/eclipse-mylyn-3.8.1-1.fc17.
Comment 6 Krzysztof Daniel CLA 2012-09-25 04:23:36 EDT 
Steffen,
 I've submitted a new patch with the  compatibility you've suggested.
 
For the purpose of IP log - I'm an Eclipse commiter (platform ui).
Comment 7 Steffen Pingel CLA 2012-10-16 04:04:22 EDT 
The change was merged. Thanks a lot for the contribution!
Comment 8 Alexander Kurtakov CLA 2012-10-16 04:25:19 EDT 
Just in time when Lucene 4.x was released upstream. :)