Bug 384452 - Download models button in preferences
Summary: Download models button in preferences
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Recommenders (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Marcel Bruch CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, usability
Depends on:
Blocks:
 
Reported: 2012-07-06 05:45 EDT by Lars Vogel CLA
Modified: 2019-07-24 14:35 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2012-07-06 05:45:26 EDT
I believe the download of the models is currently triggered the first time I try to use CR. 

Would be nice to aslo have a button in the preferences to trigger the download. This make it more explicit.
Comment 1 Marcel Bruch CLA 2012-07-06 06:21:42 EDT
This is something we considered but I didn't found the time to implement this for 1.0. I'll put this on the enhancement list. Patch welcome.
Comment 2 Timur Achmetow CLA 2013-02-27 17:11:09 EST
(In reply to comment #1)
> This is something we considered but I didn't found the time to implement this
> for 1.0. I'll put this on the enhancement list. Patch welcome.

Can you say me which plugins are affected for this job? 
Where is the class who have to be extended?
Comment 3 Marcel Bruch CLA 2013-02-28 01:11:13 EST
The code for this is hosted in o.e.recommenders.rcp. The preference page and classes  in the package o.e.r.internal.rcp.models would be affected.

Note that we have a student assistant working on this API from next week which will change the backend and repository management code completely. These changes are going into 2.0 then.
Comment 4 Timur Achmetow CLA 2013-02-28 02:39:57 EST
(In reply to comment #3)
> The code for this is hosted in o.e.recommenders.rcp. The preference page and
> classes  in the package o.e.r.internal.rcp.models would be affected.
> 
> Note that we have a student assistant working on this API from next week
> which will change the backend and repository management code completely.
> These changes are going into 2.0 then.

Hm okay, what that means for me?
Wait until the student have made his changes?
Comment 5 Marcel Bruch CLA 2013-02-28 05:16:41 EST
(In reply to comment #4)
> Hm okay, what that means for me?
> Wait until the student have made his changes?

That this is not a good candidate for a GSOC ATM ;-)
Comment 6 Timur Achmetow CLA 2013-02-28 06:14:40 EST
(In reply to comment #5)
> (In reply to comment #4)
> > Hm okay, what that means for me?
> > Wait until the student have made his changes?
> 
> That this is not a good candidate for a GSOC ATM ;-)

Yes sure, I looked for this bug as a first entry to the recommenders code, not as a GSoC project. That means I could provide a patch for this solution before the GSoC starts. 

Or you have another small interesting bugs?
Comment 7 Marcel Bruch CLA 2013-02-28 18:24:18 EST
(In reply to comment #6)
> Or you have another small interesting bugs?

Snipmatch's current code snippets do not support variables in templates. For example, trigger snipmatch in a method body and enter "file" in the search field. Select a proposal and insert it into your code. You'll notice that the inserted snippet does not support variables as templates usually do. I guess that this is because the last GSOC didn't implement it. 

How about adding the support for evaluating variables in JFAce templates to Snipmatch? You may find o.e.r.completion.rcp.templates helpful to see how we use the JFace templates to get variable support in our dynamic snippets.
Comment 8 Timur Achmetow CLA 2013-03-01 03:59:40 EST
(In reply to comment #7)
> Snipmatch's current code snippets do not support variables in templates. For
> example, trigger snipmatch in a method body and enter "file" in the search
> field. Select a proposal and insert it into your code. You'll notice that
> the inserted snippet does not support variables as templates usually do. I
> guess that this is because the last GSOC didn't implement it. 
> 
> How about adding the support for evaluating variables in JFAce templates to
> Snipmatch? You may find o.e.r.completion.rcp.templates helpful to see how we
> use the JFace templates to get variable support in our dynamic snippets.

Sound good! I will check this out, at the weekend :D
Comment 9 Timur Achmetow CLA 2013-03-01 17:01:06 EST
(In reply to comment #7)
> Snipmatch's current code snippets do not support variables in templates. For
> example, trigger snipmatch in a method body and enter "file" in the search
> field. Select a proposal and insert it into your code. 

I don't get any proposals for the keyword *file*. 
I have deployed the product from etc (ide.product). 

Maybe I have to configure some things in the preference?
Comment 10 Marcel Bruch CLA 2013-03-01 17:03:16 EST
Let's continue the discussion on the mailing list. This bug has a different purpose :)
Comment 11 Lars Vogel CLA 2013-07-17 05:06:32 EDT
I'm fine with the current implementation, I therefore close my bug. Please open a new bug if this is still planned.
Comment 12 Lars Vogel CLA 2013-10-21 05:31:47 EDT
Closing.
Comment 13 Marcel Bruch CLA 2013-10-21 05:36:57 EDT
(In reply to Lars Vogel from comment #0)
> I believe the download of the models is currently triggered the first time I
> try to use CR. 
> 
> Would be nice to aslo have a button in the preferences to trigger the
> download. This make it more explicit.

FWIW, 2.0 offers the ability to download models from within the models view.
Comment 14 Lars Vogel CLA 2013-10-21 05:37:50 EDT
Thanks for the info.