Bug 384255 - [api] alert ContextContributor about contextActivated/contextDeactivated events
Summary: [api] alert ContextContributor about contextActivated/contextDeactivated events
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.9   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.9   Edit
Assignee: Sebastian Schmidt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 378399
Blocks:
  Show dependency tree
 
Reported: 2012-07-04 07:20 EDT by Sebastian Schmidt CLA
Modified: 2012-07-17 08:26 EDT (History)
3 users (show)

See Also:

Attachments
mylyn/context/zip (9.18 KB, application/octet-stream)
2012-07-05 07:13 EDT, Sebastian Schmidt CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Schmidt CLA 2012-07-04 07:20:43 EDT 
In most cases, a ContextContributor will become active as soon as a context is activated... and inactive as soon as the context becomes deactivated. For example, a breakpoint contributor will track user interactions with breakpoints exactly when a context is activated in order to attach them to the context.

While it's possible to implement a ContextListener paired with each ContextContributor, I was thinking about adding contextActivated/contextDeactivated methods to the IContextContributor interface to avoid this dependency. Does this make sense?
Comment 1 Sebastian Schmidt CLA 2012-07-05 07:13:09 EDT 
Created attachment 218330 [details]
mylyn/context/zip
Comment 2 Sebastian Schmidt CLA 2012-07-05 07:14:00 EDT 
proposed implementation: https://git.eclipse.org/r/#/c/6625/
Comment 3 Steffen Pingel CLA 2012-07-15 12:27:19 EDT 
Makes sense to me. I added a few comments to the review. Would be great if you update the patch set and post the usual contributor blurb in Gerrit. I would then merge the change.
Comment 4 Steffen Pingel CLA 2012-07-17 08:26:53 EDT 
The code review was merged into master. Thanks for the contribution, Sebastian!