Bug 384069 - move breakpoint support to separate bundle
Summary: move breakpoint support to separate bundle
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.9   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 155333
  Show dependency tree
 
Reported: 2012-07-02 13:00 EDT by Steffen Pingel CLA
Modified: 2012-07-04 10:12 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2012-07-02 13:00:40 EDT 
The breakpoint support is not coupled to Java and should be moved to a separate bundle. This bundle would also contribute core and ui support for managing breakpoints as part of the context.
Comment 1 Steffen Pingel CLA 2012-07-02 13:04:00 EDT 
Sebastian, is the assumption in the description correct? Do you think we'll need specific support from the language bridges to manage breakpoints?

I would propose to call the bundles:

org.eclipse.mylyn.debug.core
org.eclipse.mylyn.debug.tests
org.eclipse.mylyn.debug.ui

Shawn, what are your thoughts on that?
Comment 2 Steffen Pingel CLA 2012-07-02 14:00:10 EDT 
FocusBreakpointsViewAction and FocusDebugViewAction would likely be moved to the new component. This would also ease reuse for other languages, e.g. C++.
Comment 3 Sebastian Schmidt CLA 2012-07-02 14:17:57 EDT 
I *hope* that breakpoint support is language independent as I'm using the IBreakpoint interface from o.e.core.model.IBreakpoint. Anyway, it might be that we need additional label provider for different (e.g. c++) breakpoints. I'll test that.

The naming sound good. I already added FocusBreakpointsViewAction and the corresponding InterestFilter to the new plugin as suggested (https://git.eclipse.org/r/#/c/6338/).
Comment 4 Steffen Pingel CLA 2012-07-03 09:53:30 EDT 
Ok, thanks. I might just go ahead and create these plug-ins since the contribution gets very big otherwise and there isn't really anything relevant other than bundle boilerplate.
Comment 5 Sebastian Schmidt CLA 2012-07-03 10:29:29 EDT 
Sounds great!
Comment 6 Shawn Minto CLA 2012-07-03 13:26:09 EDT 
THis sounds like a great plan to me.  Would these be then included as a part of the IDE feature or each of the CDT and Java features?  Seems that there should be a feature that java and cdt can depend on to get this support.
Comment 7 Steffen Pingel CLA 2012-07-03 15:47:54 EDT 
(In reply to comment #6)
> THis sounds like a great plan to me.  Would these be then included as a part of
> the IDE feature or each of the CDT and Java features?  Seems that there should
> be a feature that java and cdt can depend on to get this support.

I was wondering about that, too. The IDE feature could make sense or we may end up creating another debug feature. I might put it into the Java package initially since I don't want to pull in more dependencies in the IDE feature but I haven't looked at that in detail.
Comment 8 Steffen Pingel CLA 2012-07-04 09:36:59 EDT 
Pushed review here: https://git.eclipse.org/r/#/c/6607/. Turns out that we may not need a core bundle. Sebastian, does that look right to you?
Comment 9 Steffen Pingel CLA 2012-07-04 10:12:12 EDT 
I merged the change. I added the o.e.m.debug.ui bundle to the Java bridge feature for now but we can move that based on how dependencies of the bundle evolve.