Bug 383842 - Omit use of gdk_drawable_get_size() deprecated method in GC
Summary: Omit use of gdk_drawable_get_size() deprecated method in GC
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-06-28 15:24 EDT by Anatoly Spektor CLA
Modified: 2013-05-24 09:34 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anatoly Spektor CLA 2012-06-28 15:24:28 EDT 
Build Identifier: R3_7_1

This patch implements use of gdk_pixmap_get_size() to determine pixmap size, gdk_window_get_width() and gdk_window_get_height() to determine size of drawable object in GC class:

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=404d7584bf23411fc0782011ff293819d49ee74e

Reproducible: Always
Comment 1 Anatoly Spektor CLA 2012-06-29 10:39:04 EDT 
Please ignore the  patch above and refer to this patch, as I have not included os_custom.h in first one.

http://fedorapeople.org/gitweb?p=aspektor/public_git/eclipse.platform.swt.git;a=commit;h=cf48c720392f69ff6a90693afedf0e591bf4a335

 Sorry for the confusion.
Comment 3 Silenio Quarti CLA 2012-08-01 11:56:38 EDT 
Our auto build detected 64 bit problems with the patch. The rerturn value of gdk_window_get_width/gdk_window_get_height is not a "int /*long*/".

It is possible to detect these problems while developing by installing the SWT tools, selecting the org.eclipse.swt project, pop-up menu and check (SWT Tools -> Report 64 bit problems).


http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2d0d1fe9d220400e0b4957016ec81f97281b8e3b