Bug 383699 - simplify PHP page logic related to dlconfig2.txt
Summary: simplify PHP page logic related to dlconfig2.txt
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 19:11 EDT by David Williams CLA
Modified: 2012-06-27 19:11 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-06-27 19:11:19 EDT
There are about 10 PHP pages that still use this sort of dlconfig file to "read data" and based on that, compute the value of various php variables. 

But, in most cases, its always simpler to simply put the values right in a php file, such as has been done for dlconfig3.php and dlconfig4.php and additionally (most recent) a buildProperties.php file we create during the build, which can hold important values such as buildId, etc., so they do not have to be "recomputed" based on hints from dlconfig files. 

The use of dlconfig file likely goes back to 10 years ago! but, in many cases overcomplicates logic and leads to errors, such as bug 381950 not to mention "wastes" a little disk access and/or "computation cycles" that are not really needed (though, I'm sure would not be measurable performance difference).