Bug 383687 - [patch] Memory view is not updated when using Platform renderings
Summary: [patch] Memory view is not updated when using Platform renderings
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.3 M1   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 384622
  Show dependency tree
 
Reported: 2012-06-27 15:26 EDT by Nobody - feel free to take it CLA
Modified: 2012-08-31 09:47 EDT (History)
4 users (show)

See Also:

Attachments
Proposed fix. (884 bytes, patch)
2012-07-03 17:18 EDT, Nobody - feel free to take it CLA 		Michael_Rennie: iplog+
Michael_Rennie: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2012-06-27 15:26:46 EDT 
The content of the Memory view is not updated when using one of the Platform supplied rendering. 
The cause of the problem is the "installed" flag of 'MemoryBlockProxy' is never get set. I think it should be done when 'MemoryBlockProxy.installed()' is called in 'AsynchronousModel.installModelProxy()'.
We can fix it in CDT by registering a DSF/GDB specific model proxy but I believe it should be fixed by the Platform.
Pawel, can you please comment?
Comment 1 Nobody - feel free to take it CLA 2012-06-28 13:40:53 EDT 
This problem is the result of changes made for https://bugs.eclipse.org/bugs/show_bug.cgi?id=161435.
Comment 2 Nobody - feel free to take it CLA 2012-07-03 17:18:57 EDT 
Created attachment 218238 [details]
Proposed fix.
Comment 3 Michael Rennie CLA 2012-07-05 11:27:18 EDT 
Thanks for the patch Mikhail. Pushed to master:

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=7f838d36513ed33979239489e0dac691b5272d7c
Comment 4 Nobody - feel free to take it CLA 2012-07-09 10:58:56 EDT 
(In reply to comment #3)
> Thanks for the patch Mikhail. Pushed to master:
> 
> http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=7f838d36513ed33979239489e0dac691b5272d7c

Thanks Michael. Is it possible to apply it to the maintenance branch as well?
Comment 5 Pawel Piech CLA 2012-08-31 09:47:34 EDT 
Verified on:
Version: 4.2.1
Build id: M20120829-1200