Bug 38216 - [KeyBindings] KeySupport.java should support localized key sequences
Summary: [KeyBindings] KeySupport.java should support localized key sequences
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Chris McLaren CLA
QA Contact:
URL:
Whiteboard:
Keywords: nl
Depends on:
Blocks:
 
Reported: 2003-05-28 17:58 EDT by Hwa Truong CLA
Modified: 2003-06-04 21:36 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hwa Truong CLA 2003-05-28 17:58:16 EDT
Translator had a question about the need of certain strings to be externalized.

Key values are in English in the Keys Preferences page.

Steps to recreate:
1. Select Window -> Preferences 
2. Select Workbench -> Keys 
3. Select any item in the Commands box 
4. Press the pull down button next to the Key secuence field 

Question from translator:
We observed that the keys are displayed in English, however there is a file 
named: 
eclipse\plugins\org.eclipse.ui.workbench\workbench_jar\org\eclipse\ui\internal\c
ommands\keysupport.properties 
that seems to contain the translation for the keys.
Should these keys be translated or should they be displayed in English?
Comment 1 Tod Creasey CLA 2003-05-30 15:08:18 EDT
Should consider for 2.1.1
Comment 2 Chris McLaren CLA 2003-06-03 14:18:06 EDT
fixed in 2.1.1. 
translator can now translate keysupport.properties. translator should make sure that no 
spaces are used in the translation as spaces are used to delimit keystrokes. 

keeping problem open until i can migrate fix to 3.0
Comment 3 Chris McLaren CLA 2003-06-03 14:52:49 EDT
fixed in 3.0
Comment 4 Hwa Truong CLA 2003-06-04 14:19:52 EDT
The keysupport.properties has already been translated.  Will this fix, make the 
translations viewable, or is retranslation needed?

Note the english file does have spaces in it.
Comment 5 Chris McLaren CLA 2003-06-04 21:36:02 EDT
this fix will make the translations viewable.

the fix includes an updated properties file which does not have any keys or 
values containing whitespace. leading and trailing whitespace around keys and 
values is automatically stripped, so it is not the concern. rather the concern 
was around a few two word keystroke values such as 'Arrow Up' and 'Arrow 
Down', etc. these have been renamed 'Arrow_Up' and 'Arrow_Down' until such 
time as we have a proper widget to insert key strokes wihout requiring text 
typing. the spaces currently interfere with the text widgets parsing of 
multiple keystroke keysequences, where each keystroke is delimited by a space.