Bug 380153 - Include YouTube video in doc
Summary: Include YouTube video in doc
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Doc (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 RC2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2012-05-21 10:54 EDT by Dani Megert CLA
Modified: 2012-05-25 02:45 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2012-05-21 10:54:09 EDT 
Currently the 'Fade transition on maximize (4.2 only)' What's New item refers to a video on YouTube:
http://www.youtube.com/embed/07kESXY5m2Q

The Help should be as self-contained as possible and also be available offline, hence we should include that video in the doc, unless it is really big.
Comment 1 John Arthorne CLA 2012-05-23 09:40:21 EDT 
The video is 2MB, and I think in this case it is really not worth trying to include it into the doc. The entry is understandable even when offline. I will just add a link to the video in parentheses for those who happen to be online.
Comment 3 Markus Keller CLA 2012-05-23 12:29:40 EDT 
In R4_HEAD, I get this when I try to open the N&N:

SAXParseException: The reference to entity "v" must end with the ';' delimiter.
	at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:249)
...

When I replace the &v with &v , I get a message from IE (using the default embedded help window): "This content cannot be displayed in a frame".


Furthermore, the text is also wrong, since you *cannot* return to the old effect, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=357939#c5 .

And this only went into the R4_HEAD branch and not into master.
Comment 5 Dani Megert CLA 2012-05-24 04:46:25 EDT 
(In reply to comment #4)
> Further fixes:
> 
> http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?h=R4_HEAD&id=244729953f84baf73731bbb6e89a1c0bf2a683ec

You're not there yet. Using 4.2-I20120523-1900 and IE:


This content cannot be displayed in a frame

To help protect the security of information you enter into this website, the publisher of this content does not allow it to be displayed in a frame.


And when I use Firefox I get an empty page.
 

Note that you can test your change by simply launching Eclipse out of your workspace, and then open the Help.
Comment 6 John Arthorne CLA 2012-05-24 09:36:33 EDT 
(In reply to comment #5)
> Note that you can test your change by simply launching Eclipse out of your
> workspace, and then open the Help.

I am aware of that. YouTube can't be opened in an iframe, but there is a link that opens it in another page. If this isn't acceptable then I'll just have to delete the link.
Comment 7 John Arthorne CLA 2012-05-24 09:51:11 EDT 
Ah, I forgot about the href target attribute. Fix coming...
Comment 9 Dani Megert CLA 2012-05-25 02:45:14 EDT 
Verified in 4.2-I20120524-2100.