Community
Participate
Working Groups
When selecting an actionSet on the "Command Groups Availability" tab, the menubar details and toolbar details are empty. Caused by the changes for bug bug 319704, the CustomizePerspectiveDialog now needs to revert its code that dealt with actionSets. PW
*** This bug has been marked as a duplicate of bug 378845 ***
Even with the actionSet code resurrected, using the workbench model to generate the toolbar visibility and menu visibility tree seems to only show up Command Group availability paths if the actionSets have already been turned on. We should be generating the CPD model and making sure it is filled in to allow all of the contributions to be available for scraping. PW
This dialog is still completely broken in master. E.g. when I enable the Git command group and then close and reopen the dialog, I still cannot configure the Git menu; and the command groups tab also doesn't show the menu items. And the tool bar tab shows command names that are not visible anywhere. It should show the tooltip contents, as in 3.8.
See also bug 383569.
The "Customize Perspective" feature is still severely broken in Kepler (tested on both a freshly installed "Eclipse Standard" and "Eclipse Java" (both with build id 20130614-0229), compared to Indigo. E.g. select "Window/Customize Perspective" with the standard "Java" perspective active, go to "Menu Visibility". On "Eclipse Standard" there are no "Source" and "Refactor" items at all. On "Eclipse Java" they are available, but "greyed out". If you try to select them, you get e.g. a '"Source" cannot be made visible because it is in the unavailable "null" command Group.' dialog. Almost the same message appears if you "hover over" the items with the mouse. Other entries in ""Menu Visibility" are missing many sub-entries, e.g. for "Navigate" entries "Open Type Hierarchy", "Open Call Hierarchy", "Open Hyperlink" etc. etc. are absent, so one cannot hide those menu items. On "Command Groups Availability" the column "Menubar details" is completely empty (for all entries).
The initialization of the Customize Perspective Dialog appears to behave identically in 3.8 and 4.x. However, I noticed that in the event handler added with actionSetsViewer.addSelectionChangedListener(), there were contribution items that were present in 3.8 that were missing in 4.x for certain actionSets (Breakpoints, Editor Navigation, etc.). The next step is to figure out where the contribution items are being added to the actionSets and see if that piece of code is working correctly.
Created attachment 242252 [details] TreeItem creation log for 3.x CPD
Created attachment 242253 [details] TreeItem creation log for 4.x CPD
I've pushed up a new changeSet, based on the one you created at https://git.eclipse.org/r/#/c/25821 Please pull down the latest changeset before you start work today. Most of the work was to get the customizeActionBars menu and coolbar processed in a similar way to a read workbench window. I've expanded on your work in org.eclipse.ui.internal.dialogs.CustomizePerspectiveDialog.loadMenuAndToolbarStructure() to make sure that we fill in and use the customizeActionBars menu and coolbar/model in the CPD. Some good news. More icons show up in the toolbar side in the CommandGroupAvailability page. Also, if you hide something (like the menu>File>Print item) and then try to show it, you no longer get that error message about the command group being unavailable. 2 problems that need investigating: 1) on the Toolbar page, the basic items in File seem to be missing, like save, save all, and print. Could you investigate if they are being processed? 2) The actionSet Convert Line Delimiters appears in the command group page, but no menu structure appears. It seems like Convert Line Delimiters To> submenu doesn't appear in the MMenu structure. In theory it should be filled in from the actionSets + a reconcileManagerToModel call. Please investigate. PW
(In reply to Paul Webster from comment #9) > I've pushed up a new changeSet, based on the one you created at > https://git.eclipse.org/r/#/c/25821 > > Please pull down the latest changeset before you start work today. > > Most of the work was to get the customizeActionBars menu and coolbar > processed in a similar way to a read workbench window. I've expanded on > your work in > org.eclipse.ui.internal.dialogs.CustomizePerspectiveDialog. > loadMenuAndToolbarStructure() to make sure that we fill in and use the > customizeActionBars menu and coolbar/model in the CPD. > > Some good news. More icons show up in the toolbar side in the > CommandGroupAvailability page. Also, if you hide something (like the > menu>File>Print item) and then try to show it, you no longer get that error > message about the command group being unavailable. > > 2 problems that need investigating: > > 1) on the Toolbar page, the basic items in File seem to be missing, like > save, save all, and print. Could you investigate if they are being > processed? I'm following on your patch and have now the state with those buttons. > 2) The actionSet Convert Line Delimiters appears in the command group page, > but no menu structure appears. It seems like Convert Line Delimiters To> > submenu doesn't appear in the MMenu structure. In theory it should be > filled in from the actionSets + a reconcileManagerToModel call. Please > investigate. This is on my list, I'm debugging it right now. Beside this: good news: the patch https://git.eclipse.org/r/25565 applied on head allows us to see Search and Refactor menus, along with other action set based menu contributions (see bug 391430 comment 50).
Please review my patches: bug 420956 comment 11.
Thanks Andrey. I'll try to get to it on Monday Jan 12th. PW
(In reply to Paul Webster from comment #12) > Thanks Andrey. I'll try to get to it on Monday Jan 12th. I started looking at Andreys patch series and hope that I can merge a few of the easier ones of that you can focus on Monday on the heavier ones.
*** Bug 456998 has been marked as a duplicate of this bug. ***
Fixed with patches for bug 420956 in 4.5 M5 (action set details are now shown in CPD). Feel free to reopen if I missed something.
*** Bug 413657 has been marked as a duplicate of this bug. ***
