Bug 378096 - disabling toolitem that has focus does not re-assign focus somewhere valid
Summary: disabling toolitem that has focus does not re-assign focus somewhere valid
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Arun Thondapu CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, triaged
Depends on:
Blocks:
 
Reported: 2012-04-30 13:30 EDT by Grant Gayed CLA
Modified: 2019-02-01 14:07 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2012-04-30 13:30:35 EDT 
- 4.2M7 test build I20120429-1800 (with the new ToolBar implementation)
- works fine with the old ToolBar implementation

- open a .java file in the eclipse editor
- make a change in the editor so that the Save toolbar button at the top becomes enabled
- tab to this button and press Space to invoke it
- the change is saved and the Save toolbar button is disabled
- pressing tab repeatedly will reveal that focus is now nowhere, which isn't good
Comment 1 Grant Gayed CLA 2012-04-30 13:33:59 EDT 
Actually this is an accessibility problem because once focus has disappeared then other keys like Ctrl+F6 which can be used to re-locate focus become unusable.
Comment 2 Arun Thondapu CLA 2012-05-02 08:20:13 EDT 
Hi Grant,

I tested this with a M7 build (I20120427-0800) which doesn't contain my new Toolbar changes and I'm still able to reproduce the exact same behavior as described above. I even tested with a few earlier milestone builds of 4.2 to confirm and I see the same behavior there too. It worked fine for me with Indigo SR2.

So, IMO this bug is not caused by the new Toolbar implementation. I'm wondering if it needs to be fixed in UI or somewhere else but I'm not very sure. Do you think we can move it to UI for primary investigation?
Comment 3 Grant Gayed CLA 2012-05-03 11:59:13 EDT 
It's up to us to ensure that focus goes somewhere reasonable in a case like this.  I believe the swt framework takes care of doing this in the case of a focused Control becoming disabled, but ToolBar/ToolItem may need some additional lines to consider this case since ToolItems are not Controls.
Comment 4 Amaravathi Yagati CLA 2013-06-10 05:15:42 EDT 
Hi Grant,
  Do we have any workaround for this. We also face the same issue with eclipse 4.2 .
Comment 5 Grant Gayed CLA 2013-06-12 10:37:09 EDT 
Moving to Arun.  I've confirmed the behaviour change by comparing the comment 0 steps between Eclipse 3.7.2 and 4.3.
Comment 6 Xi Yan CLA 2018-12-19 10:17:44 EST 
I cannot tab to the save button in I20181206-0815. Is this still relevant?
Comment 7 Eric Williams CLA 2019-02-01 14:07:51 EST 
I cannot reproduce this issue with SWT from master, GTK3.24, and Fedora 29.