Bug 376910 - Site login needs to update more places.
Summary: Site login needs to update more places.
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Website (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 critical (vote)
Target Milestone: ---   Edit
Assignee: Denis Roy CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 314404 408131 (view as bug list)
Depends on: 384664 426956
Blocks:
  Show dependency tree
 
Reported: 2012-04-16 15:21 EDT by Eclipse Webmaster CLA
Modified: 2019-11-20 11:14 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eclipse Webmaster CLA 2012-04-16 15:21:00 EDT
When a committer changes their email address via site login we presently only update their Ldap record and Bugzilla. However other places also need this update: Gerrit,IPzilla,Mailman,Foundation and possibly Wiki and the Forums.

-M.
Comment 1 Denis Roy CLA 2012-07-05 10:29:36 EDT
I've done forums from bug 353872.
Comment 2 Denis Roy CLA 2013-05-16 15:18:33 EDT
Marketplace
Comment 3 Denis Roy CLA 2013-05-16 15:22:13 EDT
*** Bug 408131 has been marked as a duplicate of this bug. ***
Comment 4 Thanh Ha CLA 2013-05-16 15:35:18 EDT
I guess this would affect the Forges' instances of the services too.
Comment 5 Denis Roy CLA 2013-05-16 15:45:33 EDT
(In reply to comment #4)
> I guess this would affect the Forges' instances of the services too.

Um, yup.
Comment 6 Christopher Guindon CLA 2013-05-16 16:26:56 EDT
I just want to make sure I understand the problem. 

We need to come up with a patch for the drupal site login to merge an account when the user made a change to his email address?

I am assuming that right now, it's creating a new user in the drupal database.
Comment 7 Nathan Gervais CLA 2013-05-16 19:43:56 EDT
(In reply to comment #6)
> I just want to make sure I understand the problem. 
> 
> We need to come up with a patch for the drupal site login to merge an
> account when the user made a change to his email address?
> 
> I am assuming that right now, it's creating a new user in the drupal
> database.

If we are doing a user_load_by_name when loading the user, than I think we're ok.  The next time a user login the email / first / last will be updated from the Friends class.
Comment 8 Denis Roy CLA 2013-05-16 21:47:57 EDT
(In reply to comment #6)
> I just want to make sure I understand the problem. 
[snip]
> I am assuming that right now, it's creating a new user in the drupal
> database.

Not just in Drupal -- every other piece of software we run maintains its own user table: Bugzilla, Forums, Marketplace, Wiki, Gerrit, etc.  If email changes do not update the user tables in those applications, a new user account is created when someone logs in.

And as Thanh mentions, now that authentication is centralized for all the forges, multiply all that by three (for now).

If the drupal Site Login is handling email changes, those should perhaps go in the account_requests table so that we can update all the other sources.
Comment 9 Denis Roy CLA 2013-06-21 14:37:34 EDT
> When a committer changes their email address via site login we presently
> only update their Ldap record and Bugzilla. However other places also need
> this update: Gerrit,IPzilla,Mailman,Foundation and possibly Wiki and the
> Forums.


> And as Thanh mentions, now that authentication is centralized for all the
> forges, multiply all that by three (for now).

It becomes clear to me that all these updates should be handled by our Community Creator.  Since it's run on each forge and it pulls data from the same account tables, we can tune it to tweak local auth settings stored on each forge from one central location.


> If the drupal Site Login is handling email changes, those should perhaps go
> in the account_requests table so that we can update all the other sources.

Nathan, Chris ... Is it?
Comment 10 Denis Roy CLA 2013-10-18 10:57:04 EDT
Target for 2014 Q1.  This is really annoying.
Comment 11 Denis Roy CLA 2013-12-06 13:18:38 EST
(In reply to Denis Roy from comment #8)
> user table: Bugzilla, Forums, Marketplace, Wiki, Gerrit, etc.  If email

Bugzilla:    updates
Forum:       updates
Marketplace: does not update
Wiki:        updates
Gerrit:      updates
EclipseCon:  does not update
IPZilla:     does not update
Mailman:     does not update
PMI:         does not update
Foundation:  updates
Comment 12 Christopher Guindon CLA 2013-12-06 13:21:26 EST
(In reply to Denis Roy from comment #11)
> (In reply to Denis Roy from comment #8)
> > user table: Bugzilla, Forums, Marketplace, Wiki, Gerrit, etc.  If email
> 
> Bugzilla:    updates
> Forum:       updates
> Marketplace: does not update
> Wiki:        updates
> Gerrit:      updates
> EclipseCon:  does not update
> IPZilla:     does not update
> Mailman:     does not update
> PMI:         does not update
> Foundation:  updates

Denis, let's talk about this in our next weekly meeting. I am curious to know how you are dealing with this on the wiki, forum and bugzilla. 


Maybe you have something that we could leverage with drupal?
Comment 13 Denis Roy CLA 2013-12-06 13:30:53 EST
> Denis, let's talk about this in our next weekly meeting. I am curious to
> know how you are dealing with this on the wiki, forum and bugzilla. 

SELECT id FROM table WHERE email = $oldemail
UPDATE table SET email = $newemail WHERE id = $id LIMIT 1
addLogEntry("Winning");
Comment 14 Denis Roy CLA 2013-12-10 13:33:24 EST
As we've casually discussed, we simply update values in the SQL databases.  I suspect we can do the same with the various Drupals.

It is, however, one point worthy of consideration: each and every time we enable some site (or software) that maintains local copies of user data, we have to sync it.
Comment 15 Denis Roy CLA 2014-07-31 13:40:19 EDT
> PMI:         does not update

on dbmaster.projects
update users set mail = "new" where users.name = "id";
Comment 16 Christopher Guindon CLA 2014-09-23 09:58:24 EDT
*** Bug 314404 has been marked as a duplicate of this bug. ***
Comment 17 Christopher Guindon CLA 2014-09-23 10:08:24 EDT
When the user changes his eclipse account e-mail and then logs in to marketplace or another drupal site, a new account is created. 

Do we need to create some kind of account merging tool or should we only update e-mail addresses going forward?

We should also verify if an account already exist before updating the user table for a drupal site. 

In drupal, it's possible for an admin to manually create an account for a user before the user update his e-mail address.
Comment 18 Christopher Guindon CLA 2016-02-19 16:03:21 EST
(In reply to Christopher Guindon from comment #17)
> When the user changes his eclipse account e-mail and then logs in to
> marketplace or another drupal site, a new account is created. 
> 
> Do we need to create some kind of account merging tool or should we only
> update e-mail addresses going forward?
> 
> We should also verify if an account already exist before updating the user
> table for a drupal site. 
> 
> In drupal, it's possible for an admin to manually create an account for a
> user before the user update his e-mail address.

Our drupal site_login module handle this now.
Comment 19 Denis Roy CLA 2017-11-26 09:22:39 EST
Chris, I think this can be closed?
Comment 20 Christopher Guindon CLA 2017-11-28 12:27:36 EST
(In reply to Denis Roy from comment #19)
> Chris, I think this can be closed?

All Drupal sites update email addresses on user login and with a cron job for users that don't login to each of our sites.


Matt can you confirm that LCC is updating email addresses for Gerrit, IPzilla, Mailman, Foundation, Wiki and the Forums?
Comment 21 Eclipse Webmaster CLA 2017-11-28 16:41:25 EST
(In reply to Christopher Guindon from comment #20)

> Matt can you confirm that LCC is updating email addresses for Gerrit,
> IPzilla, Mailman, Foundation, Wiki and the Forums?

Yes, all of those are updated on Eclipse.org when an email address changes.

The forges(and related services) are not updated, so those are still a sticking point.  However with the plan to eventually fold those services back into Eclipse.org it may be moot.

-M.
Comment 22 Eclipse Genie CLA 2019-11-19 04:42:37 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 23 Christopher Guindon CLA 2019-11-20 11:14:01 EST
(In reply to Eclipse Webmaster from comment #21)
> (In reply to Christopher Guindon from comment #20)
> 
> > Matt can you confirm that LCC is updating email addresses for Gerrit,
> > IPzilla, Mailman, Foundation, Wiki and the Forums?
> 
> Yes, all of those are updated on Eclipse.org when an email address changes.
> 
> The forges(and related services) are not updated, so those are still a
> sticking point.  However with the plan to eventually fold those services
> back into Eclipse.org it may be moot.
> 
> -M.

Closing