Bug 376811 - Need to add "status" and "nightlies" section to 4.2 page
Summary: Need to add "status" and "nightlies" section to 4.2 page
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 376182
  Show dependency tree
 
Reported: 2012-04-14 20:04 EDT by David Williams CLA
Modified: 2012-04-23 12:58 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-04-14 20:04:28 EDT
Currently finds/displays releases, stable, and I builds, but not nightlies. 

I noticed because I just removed the (empty) "4.1 maintenance" section. 



Eventually need to remove the "nightlies" section from 3.8 pages (since, they won't be changing, since no 3.8 nightly builds planned).
Comment 1 David Williams CLA 2012-04-14 22:42:25 EDT
I fixed the "createIndex4x.php" do it does the right thing ... if build types present, it displays them, if not does not display empty sections.  So ... should fix itself once we start producing N builds there. 

But ... its worse than I first realized :) ... there's a "status" column on 3.8 pages that are not on 4.2 page ... I guess never there since a "derived build"?

So, a) should care back some of of the fixes I made to createIndex4x.php back to a createIndex3x.php page (currently, 3.8 just uses a page called eclipse3x.php) and gets more confusing from there, and 

b) eventually add the "status" column to 4.2 build pages.
Comment 2 David Williams CLA 2012-04-14 22:56:14 EDT
Just to leave a note, 

There is a files named 
42m6-news
in .../eclipse/downloads/drops4/

This was cause some weird PHP errors and warnings, and ... php and the web in general being very forgiving of errors :) did not really cause any harm ... but, I fixed by adding a "constraint" that directory entires in 
.../eclipse/downloads/drops4/
must start with one of the defined "drop types" R, I, N, M, S, etc. or will be ignored (for downloads page). 

FYI, I obsoleted the dlconfig4.txt file and added instead a dlconfig4.php file. (You'll like that little trick ...  :)
Comment 3 David Williams CLA 2012-04-15 02:16:04 EDT
FYI, I added a "downloadsites" directory the eclipsebuilder. Not sure if or what other repo they might have existed in but figured it provide a safe place to keep them, and a little more tracking of changes, as I'm making to createIndex4x.php and eclipse3x.php ... though, granted, I've already made most of those changes before I thought of this ... now they'll be there for future changes (that I'm sure will be needed).
Comment 4 David Williams CLA 2012-04-15 18:51:43 EDT
the 3.8 and 4.2 "main" pages are now very similar, almost identical. 

The key files are

For, 4.2, intended to produce 'index.html' (there should be not index.php, if there was it would be identical to createIndex4x.php). 

createIndex4x.php
dlconfig4.php

The command

php createIndex4x.php > index.html

will "scan" the drops4 directory and update the build summaries based on what it finds. 


For 3.8, intended to produce 'eclipse3x.html' 
eclipse3x.php
dlconfig3.php

The command

php eclipse3x.php > eclipse3x.html

will "scan" the drops directory and update the build summaries based on what it finds. 

External (or internal) links should never link directly to the PHP files, for 
4.2, use 
http://download.eclipse.org/eclipse/downloads/
or 
http://download.eclipse.org/eclipse/downloads/index.html

for 3.8 use 
http://download.eclipse.org/eclipse/downloads/eclipse3x.html
Comment 5 David Williams CLA 2012-04-15 18:59:16 EDT
I'll count this as fixed, but some issues may have to be revisited. 

* I removed all links/icons to "performance tests" ... I know we don't have them for 4.2 and not sure what we have for 3.8 ... but, as a shortcut, I just commented out that section. 

* There is a piece of code that uses an file from the build to decide its "done". That was some swt*zip.md5 file for 3.8. Since we do not have that for most "old" 4.2 builds, for 4.2 I just used a basic eclipse-sdk*zip file as an indication it was done. There may be times the build says its done, when it still have 10 or 15 minutes to produce the remaining files? 

* Similar for "tests". apparently 3.8 test results are put in a directory named "testresults" but in 4.2 put in a folder called "results". I just "wiggled around" the difference for now, but once we start running tests again in 4.2, may have to revisit.
Comment 6 David Williams CLA 2012-04-15 19:05:45 EDT
whoops, messed up the link from icon to test results.
Comment 7 David Williams CLA 2012-04-15 19:34:18 EDT
mostly fixed. Some "function" (icons) probably lost ... open new bugs if anyone misses them.