Bug 376683 - N builds hard coded to use R3_development for eclipse.platform.ui.git
Summary: N builds hard coded to use R3_development for eclipse.platform.ui.git
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 376182
  Show dependency tree
 
Reported: 2012-04-13 01:21 EDT by David Williams CLA
Modified: 2012-04-25 16:00 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-04-13 01:21:07 EDT
I'm sure I'll figure this out after staring at it enough ... but ... obviously wrong now for 4.2 primary builds ... and some how? needs to take effect for 3.8 builds ... or .. maybe just removed and this now handled by repositories.txt? 



        <condition property="fetchTag"
            value="CVS=HEAD,GIT=master;git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git=R3_development">
            <equals arg1="${buildType}" arg2="N" />
        </condition>
Comment 1 David Williams CLA 2012-04-13 01:25:10 EDT
This bit of coding also looks a bit suspcious, but not sure: 

        <condition property="fetchjetty" value="true">
            <equals arg1="${buildType}" arg2="N" />
        </condition>
Comment 2 David Williams CLA 2012-04-13 15:36:57 EDT
(In reply to comment #1)
> This bit of coding also looks a bit suspcious, but not sure: 
> 
>         <condition property="fetchjetty" value="true">
>             <equals arg1="${buildType}" arg2="N" />
>         </condition>

I just removed this code. I couldn't find a "fetchjetty" property anywhere, so assume its something left over from past releases?
Comment 3 David Williams CLA 2012-04-13 15:42:06 EDT
(In reply to comment #0)

>         <condition property="fetchTag"
>            
> value="CVS=HEAD,GIT=master;git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git=R3_development">
>             <equals arg1="${buildType}" arg2="N" />
>         </condition>

But, my complements to who ever wrote the code that makes use of "fetchTag". 

I changed this clause as follows for 4.2 N builds: 

<condition property="fetchTag"

     value="CVS=HEAD,GIT=master;git://git.eclipse.org/gitroot/platform/eclipse.platform.git=R4_HEAD;git://git.eclipse.org/gitroot/platform/eclipse.platform.common.git=R4_HEAD;git://git.eclipse.org/gitroot/platform/eclipse.platform.releng.git=R4_HEAD">

            <equals arg1="${buildType}" arg2="N" />
</condition>

And ... seems to work!? Auto-magically.
Comment 4 David Williams CLA 2012-04-13 15:50:00 EDT
Oh, and meant to document, this condition I changed is in "buildAll.xml" of the eclipseBuilder. There's some similar condition code in baseBuilder which I left alone, and it still says

		<condition property="fetchTag" value="CVS=HEAD,GIT=master;git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git=R3_development">
			<equals arg1="${buildType}" arg2="N" />
		</condition>

But, shouldn't matter if "fetchTag" already set. 


Also, if not obvious, this condition, in buildAll.xml, could be made a little more complicated to check both buildType and eclipseStream to do nightlies for 4.2 or 3.8. 

I'm not saying we should ... just documenting we could, if ever needed.