Bug 375908 - no more than one unstarted refresh job should be queued
Summary: no more than one unstarted refresh job should be queued
Status: VERIFIED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.1   Edit
Assignee: Lucas Panjer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2012-04-03 01:46 EDT by Lucas Panjer CLA
Modified: 2013-06-24 12:58 EDT (History)
1 user (show)

See Also:

Attachments
initial patch (1.59 KB, patch)
2012-04-04 00:23 EDT, Lucas Panjer CLA 		no flags Details | Diff
mylyn/context/zip (12.89 KB, application/octet-stream)
2012-04-04 00:23 EDT, Lucas Panjer CLA 		no flags Details
updated (1.74 KB, patch)
2012-04-05 16:10 EDT, Lucas Panjer CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Panjer CLA 2012-04-03 01:46:09 EDT 
Currently, if the builds view is refreshed multiple times in succession there may be more than one unstarted refresh job for a specific build server.

The number of unstarted refresh jobs for any one build server should be limited to 1.
Comment 1 Lucas Panjer CLA 2012-04-04 00:23:07 EDT 
Created attachment 213542 [details]
initial patch

prevent requeing of RefreshJobs that already exist in the queue based on job family
Comment 2 Lucas Panjer CLA 2012-04-04 00:23:09 EDT 
Created attachment 213543 [details]
mylyn/context/zip
Comment 3 Lucas Panjer CLA 2012-04-05 16:10:20 EDT 
Created attachment 213683 [details]
updated

max 2 queued refresh jobs
Comment 4 Steffen Pingel CLA 2012-04-25 07:22:07 EDT 
This sounds good to me. I'd prefer if we implemented a generic scheduler that managed scheduling constraints and kept track of jobs etc. since we have similar requirements in the tasks framework. I plan on taking a closer look next week but we just go with the proposed solution until we have a common abstraction in place.
Comment 5 Lucas Panjer CLA 2012-07-25 12:42:33 EDT 
Steffen, Would you like to move forward with this?
Comment 6 Steffen Pingel CLA 2012-09-17 23:37:07 EDT 
The review at https://git.eclipse.org/r/#change,7781 was merged into master. Thanks very much for the contribution!