Bug 375781 - transformedRepo is set to be identical to buildDirectory
Summary: transformedRepo is set to be identical to buildDirectory
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 355430
  Show dependency tree
 
Reported: 2012-03-31 12:38 EDT by David Williams CLA
Modified: 2012-04-11 03:19 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-03-31 12:38:20 EDT
in the buildAll.xml file, I see the defaults set for 

<!--default buildDirectory-->
<property name="buildDirectory" value="${basedir}/../src" />
<property name="transformedRepoLocation" value="${buildDirectory}" />

I find this a little confusing since "buildDirectory" will have its own 'features' and 'plugins' directories, as will the transformedRepoLocation (I am assuming, this is the transformedRepoLocation used for p2 fetches from orbit). 

It also appears to be the location where "emf pre-reqs" are put during pre-setup. 

So ... not sure if this a wildly clever trick? Or ... just a confusing pattern. :)

in some build.properties files, I see this set in a more traditional form as: 
transformedRepoLocation=${buildDirectory}/transformedRepos

(but, that property is not (can not) be actually passed in as one global value, since there are other ant scopes where it is intentionally set to "". This is discussed a little in bug 375486.   

FYI, while not related to above issue directly, thought I'd document the EMF prereq bundles are initially mirrored into 

localRepoLocation=${targetDir}/local-repo-${repoTargetId}

and then converted to "runnables" into the ${transformedRepoLocation}

This bug may just turn out to be "documenting how the eclipse build works" and not require any change to values or scripts ... but, it is confusing.
Comment 1 David Williams CLA 2012-04-11 03:19:39 EDT
Can't say there's any issues here, just looked funny. 

Also, transformedRepoLocation (if I recall right) is one of those variables that can NOT be passed in on the command line, as parts of the ant scripts (with different scopes) define it differently (since parts of the eclipse builder calls PDE build targets directly to make its own "special features" to use for temporary parts of the construction or provisioning.