Community
Participate
Working Groups
Our editor has an action which show/hide our editor's toolbars, and one of the toolbars has a combo box on it. Once the bar is hidden, it can't be shown until the editor is reopened. Attached code doesn't work on 2.1, but it just works fine on 2.0.x. To recreate: 1. start run-time workbench with attached plugin 2. create a simple project 3. create a file named 'test.w'. Two toolbars will be shown when the file is opened by a editor for extension 'w'. One toolbar has a show/hide toggle action button, and the other has a combobox on it. 4. click the show/hide toggle action button on the toolbar Then the toolbar which has the combobox will be hidden. 5. click the show/hide toggle action button again. This should show the combobox toolbar again.
Created attachment 4861 [details] test plugin
I'm seeing the following error with this plug-in. Do you have errors in your .log file? Is there something else that needs to be fixed in this plug- in? java.lang.IllegalArgumentException: Argument not valid at org.eclipse.swt.SWT.error(SWT.java:2331) at org.eclipse.swt.SWT.error(SWT.java:2275) at org.eclipse.swt.widgets.Widget.error(Widget.java:389) at org.eclipse.swt.widgets.CoolBar.setItemOrder(CoolBar.java:709) at org.eclipse.swt.widgets.CoolBar.setItemLayout(CoolBar.java:680) at org.eclipse.ui.internal.CoolBarManager.restoreState (CoolBarManager.java:692) at org.eclipse.ui.internal.WorkbenchWindow.restoreState (WorkbenchWindow.java:1313) at org.eclipse.ui.internal.Workbench.restoreState(Workbench.java:1263) at org.eclipse.ui.internal.Workbench.access$10(Workbench.java:1223) at org.eclipse.ui.internal.Workbench$12.run(Workbench.java:1141) at org.eclipse.core.internal.runtime.InternalPlatform.run (InternalPlatform.java:889) at org.eclipse.core.runtime.Platform.run(Platform.java:413) at org.eclipse.ui.internal.Workbench.openPreviousWorkbenchState (Workbench.java:1093) at org.eclipse.ui.internal.Workbench.init(Workbench.java:870) at org.eclipse.ui.internal.Workbench.run(Workbench.java:1373) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:845) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:461) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.basicRun(Main.java:291) at org.eclipse.core.launcher.Main.run(Main.java:747) at org.eclipse.core.launcher.Main.main(Main.java:583)
I don't see any exceptions logged in my log file. Could you try with a fresh workspace?
I did this with a fresh workspace and I20030507.
I tried with I20030507 build, and the plugin just works fine, and other people also can use this plugin. My OS is Windows XP. Could you try again with Eclipse 2.1 or 2.0.x?
Do you have any updates? This is a really severe problem for us.
Nick this needs to be fixed for 2.1.1. I haven't tracked down what is going on yet, but I'm working on it.
Yes, since this is a regression, please investigate for 2.1.1.
The problem is not specific to comboboxes. The problem is specific to splitting up editor contributions and the creation of empty coolitems. I will attach a patch. To run with the patch create a directory named "bin" under your eclipse/plugins/org.eclipse.ui.workbench directory. Unzip the patch into the bin directory and start eclipse with the argument -dev bin. Please run with the patch and let me know if it solves your problems.
Created attachment 5005 [details] patch
Note the above walkback is specific to the post 2.1 development stream. Changes were made to the coolbar layout restoration code and it needs to handle the above scenario (empty coolitems for split editor contribution action bars). [Bug 38211] exists for this problem.
Released fix into R2.1.1 stream. Will be in 2.1.1 maintenance build > 20030528.
Released change into post 2.1 dev stream.
I tired with Eclipse 2.1.1 maintenance build: M20030530, but the problem still exists.
The fix did not make it into the build for some reason. I need to check with Nick and Tod about what happened.
My fault, I forgot to re-version with it. I'll do so and ask for a rebuild.
Asahata-san, were you able to verify this?
Yes, I confirmed that the problem has been fixed. Thank you very much!!
Thanks.
Verified.
