Bug 37463 - [Navigator] Should not sync with selection in Navigator and Editor
Summary: [Navigator] Should not sync with selection in Navigator and Editor
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 2.1.1   Edit
Assignee: Knut Radloff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-10 11:55 EDT by Hirotaka Matsumoto CLA
Modified: 2003-06-04 14:17 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hirotaka Matsumoto CLA 2003-05-10 11:55:06 EDT
If the resource A is opened by Editor, and the resource B is opened by
Editor, whenever the selection is changed bewteen A and B on Navigator,
the active Editor is switched. This is very very annoying if the editor
supports Drag and Drop. The previous eclipse could control this sync by
its preference but this prefs seems to be gone. It is very severe
usability issue. Need to get this prefs back for 2.1.
Comment 1 Debbie Wilson CLA 2003-05-12 16:25:56 EDT
I thought the 'Link With Editor' button on the toolbar for the 
Navigator/Package Explorer view would do this.  If you have this button 
pressed (i.e. so it appears recessed) and you change the active editor, the 
focus does not shift in the navigator.  But this doesn't work in reverse (if 
you change the focus in the navigator, the active editor does change).  Nick, 
could you comment?
Comment 2 Nick Edgar CLA 2003-05-14 11:26:58 EDT
The "Link with Editor" button currently toggles back-linking behaviour only 
(switching between editors changes view selection).  Forward-linking (changing 
view selection activates corresponding editor) is always on.  
This was changed in 2.1 to be consistent with the Package Explorer.

For 2.1.1 (and 3.0), we will change both the Navigator and Package Explorer so 
that "Link with Editor" controls both back-linking and forward-linking.  When 
turned off, no linking will occur.  The corresponding JDT PR is bug 37567.

In addition, we should support drag-hover to activate an editor.  This will 
only be done in R3.0 though.  See bug 37595.
Comment 3 Knut Radloff CLA 2003-05-14 14:08:28 EDT
Is the forward-linking only a problem with drag and drop or do you consider it 
generally bad/undesirable? Bug 22274 tracks the drag problem.
I suppose it does indeed make more sense if the "link with editor" option 
controls both directions, back and forward linking. I would still be able to 
get the forward linking by double clicking an item - sort of.
Comment 4 Knut Radloff CLA 2003-05-14 15:48:26 EDT
Released fix in HEAD. Lynne please review so I can release it in 
2_1_maintenance.
The change is in org.eclipse.ui.views.ResourceNavigator.
Comment 5 Lynne Kues CLA 2003-05-14 16:22:04 EDT
Reviewed the fix.  Works fine in double click mode.  In single click mode 
forward linking is still active even when "Link with Editor" is off.  Did you 
consider this case?
Comment 6 Knut Radloff CLA 2003-05-14 16:53:04 EDT
Actually, that's just the fact that a single click opens in single click mode. 
It's not the linking feature (although the result is the same).
Comment 7 Knut Radloff CLA 2003-05-14 17:49:51 EDT
Released fix in >20030514.
Tested with single click mode and select on hover.
Comment 8 Hirotaka Matsumoto CLA 2003-05-14 21:13:04 EDT
-> Is the forward-linking only a problem with drag and drop

Yes, this is a problem. We should turn it on/off like we did before.
Comment 9 Knut Radloff CLA 2003-05-15 09:45:41 EDT
I was asking since if we fix bug 22274 the forward linking would no longer 
interfere with drag and drop.
It makes more sense though to have the linking option control both directions. 
We should still fix bug 22274 so that one doesn't have to disable linking in 
order to drag to an editor.
Comment 10 Nick Edgar CLA 2003-05-15 10:58:37 EDT
Please investigate whether we can fix 22274, and assess the risk for putting 
this into 2.1.1.  In Windows Explorer, when you have it in single-click mode, 
it allows dragging files around without opening them.

Comment 11 Knut Radloff CLA 2003-05-20 10:01:56 EDT
The fix for bug 22274 will not be backported for 2.1.1. It is not a regression 
from 2.0 and the workaround is to turn off editor linking.
Comment 12 Knut Radloff CLA 2003-06-04 14:17:07 EDT
Verified fixed in 2_1_maintenance build 20030602