Bug 374027 - Styling for active tab in an inactive stack has become worse
Summary: Styling for active tab in an inactive stack has become worse
Status: CLOSED DUPLICATE of bug 378672
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 00:10 EDT by Deepak Azad CLA
Modified: 2013-11-11 09:00 EST (History)
7 users (show)

See Also:


Attachments
White and pale blue tabs standing out on dark theme (111.85 KB, image/jpeg)
2012-04-09 11:59 EDT, Dominik Wezel CLA
no flags Details
Choosing tab colors has an effect --- but only in the preferences panel (93.73 KB, image/jpeg)
2012-04-09 12:01 EDT, Dominik Wezel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2012-03-13 00:10:04 EDT
I20120312-1730

I am on Windows 7 and use the Windows 7 theme.

Active stack
- The active tab is white
- The inactive tabs are in blue

Inactive stack
- The active tab is in blue-gray (earlier this was white)
- The inactive tabs are in white

So now when you select an Inactive stack making it active, the tabs go through a color inversion of sorts - the blue-gray (active one) becomes white, and the white ones (inactive ones) become blue. This color inversion is quite noisy, and jarring.

I think the style of the active tab should not change (much) when the stack becomes inactive and vice versa.
Comment 1 Paul Webster CLA 2012-03-13 09:12:24 EDT
Is this the same on all platforms?

PW
Comment 2 John Arthorne CLA 2012-03-15 14:00:34 EDT
I see the same thing although I am also on Win 7.
Comment 3 Paul Webster CLA 2012-03-15 14:07:07 EDT
There were some CSS problems, especially if using the Appearance page to update, first on GTK, now on Windows, that'll be fixed in I20120315-1300

But when it's working, the 2 styles you should see:

1) the active tab on the active stack should be white, and the rest of the tabs/toolbar background should be platform dependent (I see a blue on windows 7)

2) The active tab on the inactive stack should be a gradient down to white at the bottom, and the rest of the tabs/toolbar background should be white (at least on windows 7)

This is much better than the white on white with a dark line that it used to be.

I'd be interested in CSS contributions that were an improvement on this, but unless it's much better I don't imagine more than minor tweaks.

PW
Comment 4 Deepak Azad CLA 2012-03-15 21:16:09 EDT
(In reply to comment #3)
> But when it's working, the 2 styles you should see:
> 
> 1) the active tab on the active stack should be white, and the rest of the
> tabs/toolbar background should be platform dependent (I see a blue on windows
> 7)
> 
> 2) The active tab on the inactive stack should be a gradient down to white at
> the bottom, and the rest of the tabs/toolbar background should be white (at
> least on windows 7)

This is what I was complaining about in comment 0. Instead of (2) I would rather color the inactive tabs on the inactive stack a lighter shade of color for inactive tabs on the active stack.

> I'd be interested in CSS contributions that were an improvement on this, but
> unless it's much better I don't imagine more than minor tweaks.
I suppose I can take a shot at this. I guess the best way is to use CSS Spy to figure out what needs to be changed?

Talking of minor tweaks, the attachment at bug 372542 comment 3 specifies a 'Keyline Bottom Horz.' but I do not see that in Eclipse. Was that a deliberate omission?
Comment 5 Paul Webster CLA 2012-03-16 07:17:08 EDT
(In reply to comment #4)
> This is what I was complaining about in comment 0. Instead of (2) I would
> rather color the inactive tabs on the inactive stack a lighter shade of color
> for inactive tabs on the active stack.
> 

The reason that the inactive stack was white on white was to highlight that it wasn't the focus of what you are now doing in the UI.  That metaphor must be maintained with your tweak.

PW
Comment 6 Dominik Wezel CLA 2012-04-09 11:59:27 EDT
Created attachment 213755 [details]
White and pale blue tabs standing out on dark theme
Comment 7 Dominik Wezel CLA 2012-04-09 12:01:13 EDT
Created attachment 213756 [details]
Choosing tab colors has an effect --- but only in the preferences panel
Comment 8 Dominik Wezel CLA 2012-04-09 12:01:51 EDT
I'm running 4.1 on Gentoo Linux, using the Classic theme on a dark theme.

The white / pale blue tabs are standing out in a distracting and odd way in the middle of the otherwise dark theme (see attachment 1 [details]).

I hoped to find a general appearance preference to help that, but the ones I tried only worked in the preferences dialog (see attachment 2 [details]).
Comment 9 Dominik Wezel CLA 2012-04-09 12:04:04 EDT
Sorry, wrong attachments.  Just check comments 6 and 7 for the right IDs.
Comment 10 Paul Webster CLA 2012-04-10 09:39:24 EDT
(In reply to comment #6)
> Created attachment 213755 [details]
> White and pale blue tabs standing out on dark theme

I don't think we have CSS yet to support a dark theme.  If you did part of it using preferences then we probably have a scenario where preferences and CSS are trampling over each other.  Please open a new bug for that against Platform/UI

PW
Comment 11 Markus Keller CLA 2013-11-07 08:16:46 EST
(In reply to Paul Webster from comment #5)
> The reason that the inactive stack was white on white was to highlight that
> it wasn't the focus of what you are now doing in the UI.  That metaphor must
> be maintained with your tweak.

You can't use white as "active" color and as "inactive" color in the same theme. Bug 378672 explains this in more detail.
Comment 12 John Arthorne CLA 2013-11-07 09:02:32 EST
I think this should be marked as a duplicate of bug 378672 since they are the same topic as far as I can see.
Comment 13 John Arthorne CLA 2013-11-11 09:00:53 EST

*** This bug has been marked as a duplicate of bug 378672 ***