Community
Participate
Working Groups
3.8 master - Enable Breakpoint annotation to be shown in Text as a squiggly line - Add a breakpoint via double clicking in the vertical ruler => A blue circle appears in the vertical ruler and a squiggly blue line appears in the editor. GOOD. - Remove the breakpoint via double clicking in the vertical ruler => The blue circle disappears from the vertical ruler. GOOD However, the blue squiggly line remains in the editor. BAD Things work fine for other annotations e.g. Bookmark
Works in 3.6.2 but no longer since 3.7. It also works for bookmarks. Might be some strange data in the breakpoint marker that surfaces this bug.
Observation: It works from next time if the breakpoint is added/removed via Undo/Redo. Steps: 1. Enable Breakpoint annotation to be shown in Text as a squiggly line 2. Add a breakpoint via double clicking in the vertical ruler. Blue circle and squiggly blue line appears. 3. Remove the breakpoint via double clicking in the vertical ruler. Blue circle disappears but squiggly line remains. => Bug. 4. Focus out from the editor and bring the focus to Breakpoints view. 5. Press Ctrl+Z, blue circle appears back. 6. Press Ctrl+Y, blue circle is gone along with the squiggly line.
Created attachment 229439 [details] Patch The issue is in the way ToggleBreakpointAction calls DebugUITools.deleteBreakpoints(..), while removing the breakpoint on double-clicking the breakpoint circle at the vertical ruler. (RemoveBreakpointAction also removes a breakpoint by calling DebugUITools.deleteBreakpoints(..), when user selects the breakpoint in the Breakpoints view and clicks on "Remove Selected Breakpoints" from the view's toolbar. In this case the bug does not exist as it is run as a worksapce runnable.) The patch has moved the call to DebugUITools.deleteBreakpoints(..) in ToggleBreakpointAction into a workspace runnable. Dani, please check.
Comment on attachment 229439 [details] Patch The patch makes the bug go away, but it is not fixing the broken code. The fact that the breakpoint goes away in the ruler indicates that the editor got correctly notified about the removal. Also, when typing something on the line with the blue underline, it disappears. This indicates that the bug is in the text editor infrastructure. Probably in the AnnotationPainter.
The problem was that we forgot to update 'highlightAnnotationRangeStart' and 'highlightAnnotationRangeEnd' at all places. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=0ccdaa6315d0fbc1c1697d08118cc38aca949f64
*** Bug 403401 has been marked as a duplicate of this bug. ***
