Community
Participate
Working Groups
The Run->Breakpoint Types menu is populated using a dynamic contribution implemented by org.eclipse.debug.internal.ui.actions.breakpoints.BreakpointTypesContribution. We also have a public RulerBreakpointTypesActionDelegate. Unfortunately bug 330609 breaks the latter in e4. I prpose to deprecate the old-style action delegate and make the dynamic contribution public. The dynamic contribution can be used in an editor ruler popup menu just as well as anywhere else.
I committed the change. Mike please let me know if you disagree with the api addition. http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=3c08aeeb1e0759e8fc8bca29a20e7d5ae79d504e
Didn't test it yet, but you should go back and remove the two system.out.println's from the fix :)
(In reply to comment #2) > Didn't test it yet, but you should go back and remove the two > system.out.println's from the fix :) Sorry about that, I committed a cleanup change. In gtk, if I set a breakpoint in menu creation code, my whole X session freezes. So printf's are the best debugging tool there.
(In reply to comment #3) > (In reply to comment #2) > > Didn't test it yet, but you should go back and remove the two > > system.out.println's from the fix :) > > Sorry about that, I committed a cleanup change. > > In gtk, if I set a breakpoint in menu creation code, my whole X session > freezes. So printf's are the best debugging tool there. Looking better. Now we just need some doc on the new API methods: protected IContributionItem[] getContributionItems() public void initialize(IServiceLocator serviceLocator)
(In reply to comment #4) > Looking better. Now we just need some doc on the new API methods: > > protected IContributionItem[] getContributionItems() > public void initialize(IServiceLocator serviceLocator) Hmm. They're not really meant to be referenced by clients. They only imlement/extend methods that are required by the contribution's interfaces. Is there an API tag for that (@noreference perhaps)? I.e. we don't typically document tag extensions to Action.run().
(In reply to comment #5) > (In reply to comment #4) > > Looking better. Now we just need some doc on the new API methods: > > > > protected IContributionItem[] getContributionItems() > > public void initialize(IServiceLocator serviceLocator) > > Hmm. They're not really meant to be referenced by clients. They only > imlement/extend methods that are required by the contribution's interfaces. Is > there an API tag for that (@noreference perhaps)? I.e. we don't typically > document tag extensions to Action.run(). @noreference
(In reply to comment #4) > Looking better. Now we just need some doc on the new API methods: Sorry Mike, I didn't mean to ignore the request, I just had a high-priority product issue that took my attention.
(In reply to comment #7) > (In reply to comment #4) > > Looking better. Now we just need some doc on the new API methods: > Sorry Mike, I didn't mean to ignore the request, I just had a high-priority > product issue that took my attention. No worries, its taken care of
