Bug 373012 - Update node attribute in FormTextModel
Summary: Update node attribute in FormTextModel
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.1   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2012-03-01 14:26 EST by Tim U CLA
Modified: 2019-10-02 03:26 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim U CLA 2012-03-01 14:26:12 EST
Build Identifier: 20110916-0149

org.eclipse.ui.forms.widgets.FormText has deprecated JavaDoc:

"vspace: attribute for paragraphs and lists is no longer valid: it doesn't work because in org.eclipse.ui.internal.forms.widgets.FormTextModel "addVerticalSpace" attribute is expected instead of "vspace"

Reproducible: Always

Steps to Reproduce:
Probably it's needed to update org.eclipse.ui.internal.forms.widgets.FormTextModel: replace addVerticalSpace with vspace to be consistent with JavaDoc for the FormText widget
Comment 1 Tim U CLA 2012-03-01 14:30:40 EST
Use case: need to decrease vertical space between text lines in paragraphs and  list items.

Documented, but doesn't work:
<form><p vspace="false"></p></form> 


Works fine, but not documented: 
<form><p addVerticalSpace="false"></p></form>
Comment 2 Curtis Windatt CLA 2012-03-01 14:34:13 EST
Moving to platform UI.

Can you provide a more detailed explanation of what needs to be updated? I don't see any mention of addVerticalSpace in FormText and in FormTextModel it is an attribute.  I have the 4.x code checked out currently so it may be different then what you are looking at.

Better yet, a patch would be great.
Comment 3 Curtis Windatt CLA 2012-03-01 14:36:00 EST
Taking another look, Isee that vspace is used when processing the paragraph if addVerticalSpace is not found.  However, processListItem only checks addVerticalSpace.  So perhaps this is a bug in the model code?
Comment 4 Tim U CLA 2012-03-01 15:20:44 EST
Agree, for the paragraphs it looks like vspace attribute is really read, but doesn't take any effect for me. 

But in case of list items the bug is still present:

At least in 

private Paragraph processListItem(Node listItem, boolean expandURLs) method

line 194: Node addSpaceAtt = atts.getNamedItem("addVerticalSpace");//$NON-NLS-1$

addVerticalSpace attribute is used only, no vspace attribute presents in the code. However, in the documentation the only vspace attribute is described.
Comment 5 Eclipse Genie CLA 2019-10-01 18:40:37 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.