Bug 372943 - [EditorMgmt] Cannot maximize shared area by double-clicking on the tab area after it has been split
Summary: [EditorMgmt] Cannot maximize shared area by double-clicking on the tab area a...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal with 4 votes (vote)
Target Milestone: 4.15 M1   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
: 395356 423863 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-01 02:44 EST by Sven Efftinge CLA
Modified: 2019-12-12 10:53 EST (History)
17 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Efftinge CLA 2012-03-01 02:44:57 EST
A thing I used to do in Eclipse 3.x is to open two editors and maximize the editor area in order to see moth of both of them. There is no "editor area" anymore and therefore I can only maximize one or the other editor.

Is there a similarly convenient way to do such things in Eclipse 4?
Comment 1 Thomas Schindl CLA 2012-03-01 05:34:41 EST
I'm also unable to split the editor area in M5 but I'm certain this used to work in previous milestones.
Comment 2 Remy Suen CLA 2012-03-01 06:46:36 EST
Works for me with I20120210-1700 on Windows 7.
Comment 3 Sven Efftinge CLA 2012-03-01 07:00:38 EST
It didn't work in M4 on my mac. 
In M5 (maybe it was there in M4 also) I now found the two little minimize/maximize icons in the upper right corner. With that it works on my machine (mac) as well.
However double-clicking the tab of an editor doesn't work, but double clicking the thin grey area above the editors will do the trick.
Comment 4 Remy Suen CLA 2012-03-01 07:04:48 EST
(In reply to comment #3)
> It didn't work in M4 on my mac. 
> In M5 (maybe it was there in M4 also) I now found the two little
> minimize/maximize icons in the upper right corner. With that it works on my
> machine (mac) as well.

Ah, you were looking for that, sorry about that. I assumed people maximized with Ctrl+M. Glad to hear that it's working for you now.

> However double-clicking the tab of an editor doesn't work, but double clicking
> the thin grey area above the editors will do the trick.

This however is a bug.
Comment 5 Eric Moffatt CLA 2012-04-04 11:33:46 EDT
Not really sure if this constitutes a bug. Were we to allow a double click on one of the editor stacks the intent would be ambiguous; you want it to toggle the shared *area* state but it could also mean that you want to see only the editor in the stack you double-clicked on...

For my money I'd make the shared area's 'stack' bigger but there's still too much screaming about wasted real-estate...;-).
Comment 6 Eric Rizzo CLA 2012-06-11 11:46:00 EDT
(In reply to comment #5)
> Not really sure if this constitutes a bug. Were we to allow a double click on
> one of the editor stacks the intent would be ambiguous; you want it to toggle
> the shared *area* state but it could also mean that you want to see only the
> editor in the stack you double-clicked on...

IMNSHO it should preserve the behavior from 3.x, which was to maximize the editor area, leaving all editor splits visible.
Comment 7 Ulli Hafner CLA 2012-07-24 05:56:57 EDT
I think it is quite a common use case to have two editors side by side. At least a menu item or shortcut should be available to expand all visible editor areas to fill the whole screen. Currently there is too much excise when working with multiple editor areas:
1. open editor one
2. open editor two in same editor area
3. Press CTRL-M
4. Drag and drop editor two to free space: editors are shown side by side
5. Change something in editors
6. Press CTRL-M to refocus on package explorer
After the last command I would expect that another call to CTRL-M would restore the old setup with the two editor areas. But it maximizes the focused editor. It would be very helpful if it would restore the old setup.
Comment 8 Paul Webster CLA 2012-07-24 09:31:42 EDT
(In reply to comment #7)
> After the last command I would expect that another call to CTRL-M would restore
> the old setup with the two editor areas. But it maximizes the focused editor.
> It would be very helpful if it would restore the old setup.

When I split the editor area, CTLR+M will maximize the editor area (both editors now take up the entire workbench window).

Eric, this might be a problem where it's hard to tell the difference between splitting the editor area and moving an editor out of the editor area.

PW
Comment 9 Eric Moffatt CLA 2012-07-24 13:32:23 EDT
I suspect that it's a confusion about the shared area...

The area containing the editors (whether split or not) is shared between the various perspectives. In this case you maximized the *area* with Ctrl-M, then split it. At this point both editors are still within the (currently maximized) area.

This is by intent, allowing the comparison of editor contents whilst maximized. 

Is the request to then allow an operation that permits showing only one of the two editor stacks while the area is maximized ?
Comment 10 Paul Webster CLA 2012-07-24 13:35:55 EDT
Depending on how you drag an editor when it's maximzed, sometimes it ends up in the shared area and sometimes we create a new stack beside the shared area.

The DND rectangles are slightly different, but maybe they're too close.

The behaviour expected was to have the editor area maximized again, so both editors were visible.

PW
Comment 11 Ulli Hafner CLA 2012-07-25 04:35:20 EDT
Ah, thanks for pointing that out. Indeed there are two slightly different rectangles. I did not realize that up to now! (Note that the new look and feel for the DND actions with bright green colors on Linux is quite uncommon and may lead to several problems. The old design in Eclipse 3.x is much better: for each DND operation it is always obvious where the dragged part would appear - in Eclipse 4.x this is not. E.g., when dragging a view to create a new tab in the same area is also hardly visible on Linux. I think that part of Eclipse 4.x is a step backward in usability...)
Comment 12 Eddie Galvez CLA 2012-09-07 16:31:57 EDT
+1.


it is too easy to want to take two editor tabs, put them side by side and maximize to have both editors side by side still, but all views minimized...

and end up just maximizing one of the editors

The annoying thing is even when you finally train yourself to spot the subtle distinction of editor splitting... that once you have the editor area with two editors side by side... if you double click a tab it doesn't react in a way that you might expect (yes, just maximize everybody rather than sitting there doing nothing)...
Comment 13 Kelly McGraw CLA 2014-06-12 08:26:34 EDT
Will this ever be fixed?
Comment 14 Paul Webster CLA 2014-06-12 09:18:13 EDT
No one is looking at this ATM, but we accept contributions.

PW
Comment 15 Eric Moffatt CLA 2014-06-24 14:26:59 EDT
The platform has no intent to work on this but would be more than willing to look at Gerrit patches...that's what we use the 'helpwanted' tag to indicate.

Note that this would entail somehow making the MArea's composite use a TrimmedPartLayout (to allow for putting the editor what was 'minimized' into the *area's* trim). This might also mean generalizing the layout so that it has no idea it's under a Shell. Then you'd have to change the MinMaxAddon to understand the new configuration...
Comment 16 Eclipse Genie CLA 2019-07-09 04:37:00 EDT
New Gerrit change created: https://git.eclipse.org/r/145671
Comment 17 Rolf Theunissen CLA 2019-07-10 15:31:27 EDT
*** Bug 395356 has been marked as a duplicate of this bug. ***
Comment 19 Rolf Theunissen CLA 2019-12-10 04:49:46 EST
Thanks Robert and Benedikt for fixing this
Comment 20 Dani Megert CLA 2019-12-10 05:51:12 EST
(In reply to Eclipse Genie from comment #18)
> Gerrit change https://git.eclipse.org/r/145671 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=41448180d967546a653e40b1ff9546d111b5ecf6
> 
We're at the beginning of the new release, hence make sure to increment the bundle version if you merge the first change after 4.14. I've fixed this now.
Comment 21 Rolf Theunissen CLA 2019-12-10 06:00:53 EST
(In reply to Dani Megert from comment #20)
> (In reply to Eclipse Genie from comment #18)
> > Gerrit change https://git.eclipse.org/r/145671 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=41448180d967546a653e40b1ff9546d111b5ecf6
> > 
> We're at the beginning of the new release, hence make sure to increment the
> bundle version if you merge the first change after 4.14. I've fixed this now.

Sorry, of course a overlook at my side. Also a side effect of not having to rebase if there is no overlap in Gerrit. Good practice would be to rebase Gerrits before pushing on a new release. Might be good to document that somewhere (and if possible enforce)
Comment 22 Dani Megert CLA 2019-12-10 09:05:51 EST
(In reply to Rolf Theunissen from comment #21)
> (In reply to Dani Megert from comment #20)
> > (In reply to Eclipse Genie from comment #18)
> > > Gerrit change https://git.eclipse.org/r/145671 was merged to [master].
> > > Commit:
> > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=41448180d967546a653e40b1ff9546d111b5ecf6
> > > 
> > We're at the beginning of the new release, hence make sure to increment the
> > bundle version if you merge the first change after 4.14. I've fixed this now.
> 
> Sorry, of course a overlook at my side. Also a side effect of not having to
> rebase if there is no overlap in Gerrit. Good practice would be to rebase
> Gerrits before pushing on a new release. Might be good to document that
> somewhere (and if possible enforce)
No worries! That's the consequence of the new rebase strategy, which is better in most cases.
Comment 23 Rolf Theunissen CLA 2019-12-12 10:53:04 EST
*** Bug 423863 has been marked as a duplicate of this bug. ***