Bug 37280 - [KeyBindinds] Select view/editor/perspective should have no rocker option
Summary: [KeyBindinds] Select view/editor/perspective should have no rocker option
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2003-05-06 12:09 EDT by Tod Creasey CLA
Modified: 2003-09-03 16:36 EDT (History)
1 user (show)

See Also:


Attachments
Patch to CyclePartAction, IPreferenceConstants, messages.properties, WorkbenchPreferencePage (5.87 KB, patch)
2003-09-02 13:56 EDT, Douglas Pollock CLA
no flags Details | Diff
Patch to WorkbenchPlugin (989 bytes, patch)
2003-09-03 15:33 EDT, Douglas Pollock CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2003-05-06 12:09:17 EDT
2.1

it should be possible for the list that pops up for Ctrl+Fx to stay up on key 
release - this is hard to do for users with mobility problems or those waiting 
on a screen reader.
Comment 1 Douglas Pollock CLA 2003-08-28 12:04:29 EDT
I can think of 3 solutions of the top of my head.  Any comments?

1.) A configurable preference that turns off the "rocker" effect.  Pressing
Ctrl+F6 would then open the dialog, and the dialog would stay open until Escape
or Enter is pressed.
2.) A separate command that is a "rocker"-less dialog.  Very similar to above,
but different in how its configuration is presented to the user.  Both styles of
dialog could be available to the user at the same time -- using different key
bindings to evoke each.
3.) A reserved key that makes the dialog sticky.  By pressing and holding
Ctrl+F6 and then pressing another magic key, the dialog would stay open (as
described above).  This is the easiest change, but it might not help people with
mobility problems.
Comment 2 Matthew King CLA 2003-08-29 08:53:39 EDT
Douglas, #1 is by far the best option. It will help the most people. #2 will 
tend to complicate the UI by adding yet another key binding to remember or 
requiring the user to go through the more complex task of configuring a key 
binding. #3 is going to end up requiring too many fingers.
Comment 3 Douglas Pollock CLA 2003-09-02 11:45:50 EDT
As it is right now, if the key binding triggering the part navigation is not
masked (e.g., no Ctrl, Shift, Alt or Command is included), then the quick
release mode (rocker effect) is turned off.  For example, remapping the "Next
Editor" command to "F6" makes the dialog stay up when "F6" is pressed.
Comment 4 Douglas Pollock CLA 2003-09-02 13:56:25 EDT
Created attachment 5944 [details]
Patch to CyclePartAction, IPreferenceConstants, messages.properties, WorkbenchPreferencePage

The option in this patch has been added to the main Workbench preference page,
as it applies to views, perspectives and editors.  It seems to have a rather
broad scope.  I'm not sure this is the best place for it.

CyclePartAction gets a dependency on jface, while it previously only had a
dependency on the platform/workbench.  This dependency is to provide access to
the underlying preferences.
Comment 5 Douglas Pollock CLA 2003-09-03 15:33:57 EDT
Created attachment 5963 [details]
Patch to WorkbenchPlugin

Missed a piece in WorkbenchPlugin (thanks tod).
Comment 6 Tod Creasey CLA 2003-09-03 16:36:47 EDT
Fix released into build >20030903