Bug 372356 - Can't close notifications with keyboard
Summary: Can't close notifications with keyboard
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 365361
  Show dependency tree
 
Reported: 2012-02-23 10:49 EST by Max Li CLA
Modified: 2012-03-07 15:00 EST (History)
1 user (show)

See Also:
susan: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Li CLA 2012-02-23 10:49:52 EST 
It is currently impossible to close the notification error messages with the keyboard. The close button cannot be tabbed to.
Comment 1 Max Li CLA 2012-02-23 10:52:27 EST 
This appears to be another instance of the same typo corrected in bug 371675.
Comment 2 Max Li CLA 2012-02-23 10:57:20 EST 
Here is a fix. I did a search to make sure there weren't any more cases of this and I believe this is the only one.

The commit is in the bug372356 branch.

https://github.com/max-li/orion.client/commit/71308924b5ac9ac18d91f6f387cb0317dba7810f
Comment 3 Susan McCourt CLA 2012-02-23 11:04:45 EST 
As soon as I saw the bug title I had a feeling.
sigh...tunnel vision.
Comment 4 Susan McCourt CLA 2012-02-23 11:09:13 EST 
Ken - if we end up needing to spin another build for RC3 I'd like to fix this, but it's not a build-worthy bug on it's own.  The symptom is innocuous, the cause (stupid typo) is why I'd like to fix it.
Comment 5 Susan McCourt CLA 2012-03-07 15:00:58 EST 
verified and pushed fix.