Bug 371675 - Cannot tab to Add Favorites button
Summary: Cannot tab to Add Favorites button
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 365361
  Show dependency tree
 
Reported: 2012-02-15 14:45 EST by Max Li CLA
Modified: 2012-02-16 16:54 EST (History)
0 users

See Also:
maxli: review?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Li CLA 2012-02-15 14:45:08 EST 
Using the keyboard, I am unable to tab to (and subsequently use) the Add this page to favorites button in the header.
Comment 1 Susan McCourt CLA 2012-02-15 14:49:23 EST 
thanks for double checking this Max.
Can you propose a fix?  I tried to do the right thing by stealing what you did for the commands, but clearly I forgot something.

'<span id="pageFavorite" tabindex: "0" role: "button" class="imageSprite core-sprite-favorite_sml"></span>' +


code is commonHTMLFragments line 41.
Comment 2 Max Li CLA 2012-02-15 15:44:04 EST 
It was just an amusing typo. While fixing that, I also added an accessible label to the button.

The commit is in the bug371675 branch.

https://github.com/max-li/orion.client/commit/df56a33142ee737a23e1fba14b9cbcd7936515f3
Comment 3 Susan McCourt CLA 2012-02-16 11:18:32 EST 
(In reply to comment #2)
> It was just an amusing typo. 
indeed.  more like embarrassing.  I had done that in one other place and caught it.  sigh.
Comment 4 Susan McCourt CLA 2012-02-16 16:54:34 EST 
pushed fix