Bug 372252 - need to reduce code duplication across the various explorers
Summary: need to reduce code duplication across the various explorers
Status: RESOLVED WONTFIX
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks: 367970 403483
  Show dependency tree
 
Reported: 2012-02-22 11:30 EST by Susan McCourt CLA
Modified: 2015-05-05 16:02 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-02-22 11:30:35 EST 
We have lots of copied code across our various explorers/renderers.  In some cases I'm not sure a copy is needed at all, in other cases there is a slight tweak to the original method.

We need to review all the explorers and try to generalize/abstract things like selection handling, etc.  I ran into this while trying to sprite the core.  There is repeated code for handling checkmarks and ideally this would all be taken care of in selectionRenderer.  (for example search for "selectionCheckmark")
Comment 1 Susan McCourt CLA 2012-02-22 12:12:19 EST 
the selection issues are documented in:
bug 339500, bug 359730, bug 369732.
Turns out most of the selection code is there to put "check all" boxes in the header.  If we contribute a common command for select all then we wouldn't have to have this in the explorer header.
Comment 2 libing wang CLA 2012-05-22 10:15:07 EDT 
We've already done some of this, e.g. selection model.
We still need to clean things up post 0.5.
Comment 3 libing wang CLA 2012-10-04 16:54:02 EDT 
Triage in 2.0M1.
Comment 4 John Arthorne CLA 2015-05-05 15:49:55 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
Comment 5 John Arthorne CLA 2015-05-05 16:02:41 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html