Bug 359730 - [status] odd selection model and scrolling behavior
Summary: [status] odd selection model and scrolling behavior
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on: 377018
Blocks: 349328
  Show dependency tree
 
Reported: 2011-10-03 11:49 EDT by Susan McCourt CLA
Modified: 2012-05-18 15:00 EDT (History)
2 users (show)

See Also:


Attachments
screenshot (93.41 KB, image/png)
2011-10-03 11:49 EDT, Susan McCourt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-10-03 11:49:24 EDT
Created attachment 204455 [details]
screenshot

I was trying to stage a bunch of commits and thought, "hey, where did that select all checkbox and unstage command go?"

The problem was I had scrolled down a little and didn't expect the command to scroll with it.  (since our "real" commands do not scroll, and since the compare commands on the right don't scroll.

I started to open a bug saying "the unstage command shouldn't scroll" but I think the real fix here is for us to have a common way to do select all/deselect all, and then Stage would just be a normal selection based command (up in the toolbar).
Comment 1 Tomasz Zarna CLA 2011-10-04 05:24:04 EDT
See also bug 359404.
Comment 2 Susan McCourt CLA 2012-04-13 15:02:55 EDT
Libing, I'd like to steal this bug from you because we have differing selection/scrolling/cursoring models in many places and we want to try to make these consistent for 0.5.  

(This will probably break out into a bunch of different bugs, but for now I'd like to steal it and then break it out from there....)
Comment 3 libing wang CLA 2012-04-13 15:24:25 EDT
(In reply to comment #2)
> Libing, I'd like to steal this bug from you because we have differing
> selection/scrolling/cursoring models in many places and we want to try to make
> these consistent for 0.5.  
> 
> (This will probably break out into a bunch of different bugs, but for now I'd
> like to steal it and then break it out from there....)

You are not stealing, you already let me know :-)...
Yeah, I think you mentioned a good point as well in Bug 349328 comment 19.
I am putting dependency again.
Comment 4 Susan McCourt CLA 2012-04-19 14:09:56 EDT
The original problem here will probably go away given the rework of git status in bug 349328.  We expect the "selection list" to go away, replaced by an outliner and diff sections.  However I'd like to keep it open and own it as a reminder to revisit the new git status page and ensure that we are good.
Comment 5 Susan McCourt CLA 2012-05-18 15:00:56 EDT
(In reply to comment #4)
> The original problem here will probably go away given the rework of git status
> in bug 349328.  We expect the "selection list" to go away, replaced by an
> outliner and diff sections.  However I'd like to keep it open and own it as a
> reminder to revisit the new git status page and ensure that we are good.

I think we've done the initial work here in bug 377018.  Note there is still some work to do but this is tracked in more specific bugs (bug 380004 and bug 379811)