Community
Participate
Working Groups
The "PropertyChangeEvent.getNewValue()" method for IWorkingSet PropertyChangeEvents gives the updated working set, but since "getOldValue()" returns null, and the "equals" method for working sets compares both the names and element sets, It is very difficult to determine which "old" working set actually changed. It would be very helpful (and I believe reasonable) to have getOldValue() return a copy of the IWorkingSet before modifications.
Alternatively, some unique identifier could be assigned to each working set to allow for easier comparisons.
*** Bug 37182 has been marked as a duplicate of this bug. ***
Should do as proposed and provide copy of old working set state.
Reassigning to Nick since he is taking ownership of this component.
Created attachment 81214 [details] patch to provide oldValue Kim, here is the patch we talked about, Just give me some feedback if there is something wrong with it
(In reply to comment #5) > Created an attachment (id=81214) [details] > patch to provide oldValue > > Kim, here is the patch we talked about, Just give me some feedback if there is > something wrong with it Back to inbox. Patch pending review albeit likely outdated.
reassigning according to platform UI triage process
New Gerrit change created: https://git.eclipse.org/r/43347
Gerrit change https://git.eclipse.org/r/43347 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7473c79b65462e3cd171aa57f96d96b106090c5b
Thanks for the fix, Thomasz!
Verified IWorkingSetManagerTest tests are run in N20150315-1630: http://download.eclipse.org/eclipse/downloads/drops4/N20150315-1630/testresults/xml/org.eclipse.ui.tests_linux.gtk.x86_64_8.0.xml
