Bug 37143 - [WorkingSets] API addition to IWorkingSetManager to recreate an IWorkingSet from an IMemento
Summary: [WorkingSets] API addition to IWorkingSetManager to recreate an IWorkingSet f...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 37506
  Show dependency tree
 
Reported: 2003-05-01 14:55 EDT by Darin Swanson CLA
Modified: 2003-12-08 22:56 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2003-05-01 14:55:06 EDT 
We are creating and persisting an IWorkingSet within the .launch framework to 
enable sharing of a working set.

The only problem is in the restoration of the IWorkingSet from the stored 
IMemento. We would like to not have to duplicate the code for persisting and 
restoring the working sets.

I would like to propose the following addition to IWorkingSetManager:

IWorkingSetManager.createWorkingSet(IMemento workingSetMemento)


As well it should be explict on IWorkingSet that it adapts to 
IPersistableElement.
Comment 1 Knut Radloff CLA 2003-05-06 17:38:41 EDT 
We talked about the need for this in email. Darin is handling the persistence 
himself because he does not want to add the working sets to the working set 
manager. They are internal working sets that should not be shown to the user.
Comment 2 Darin Swanson CLA 2003-05-06 18:02:50 EDT 
To see the current implementation/work arounds we are using (from HEAD):
org.eclipse.debug.ui.variables.WorkingSetComponent
org.eclipse.debug.ui.variables.WorkingSetExpander
Comment 3 Knut Radloff CLA 2003-09-02 17:18:06 EDT 
Reassigning to Nick since he is taking ownership of this component.
Comment 4 Darin Swanson CLA 2003-09-19 20:05:13 EDT 
The code in question now lives in 
org.eclipse.debug.ui.launchVariables.RefreshTab.
Comment 5 Nick Edgar CLA 2003-09-22 09:08:53 EDT 
Will investigate.  Are there any other areas where Debug is using Workbench 
internals?  We want to clean these up for the RCP work.
Comment 6 Nick Edgar CLA 2003-10-06 16:03:38 EDT 
Sorry, didn't get to it for M4.
Comment 7 Nick Edgar CLA 2003-11-17 21:56:29 EST 
Will get to this for M6.  Honest.
Comment 8 Nick Edgar CLA 2003-12-08 22:55:56 EST 
Fixed in I20031209.
Added IWorkingSetManager.createWorkingSet(IMemento) and added 
IPersistableElement to IWorkingSet as suggested.
Comment 9 Nick Edgar CLA 2003-12-08 22:56:26 EST 
Also added test in IWorkingSetManagerTest.