Bug 370806 - [Table] rewrite the "allowed contents" query selection dialog for v0.2
Summary: [Table] rewrite the "allowed contents" query selection dialog for v0.2
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 05:44 EST by Nicolas Bros CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2012-02-07 05:44:34 EST 
We must re-write this dialog for the new version of the Facet metamodel:
org.eclipse.emf.facet.widgets.table.ui.internal.jface.dialog.PresentabilityQuerySelectionDialog

The dialog should now allow selecting a boolean ETypedElement instead of a query, because the new version of the Facet metamodel doesn't have standalone "queries". Queries are replaced by ETypedElements (attributes, references and operations) contained by a Facet or EClass.

This new dialog should be testable without SWTBot, with a dialog API.
And it should not interact with the Facet manager directly.
Comment 1 Nicolas Bros CLA 2012-02-13 04:22:40 EST 
I have committed a new generic ETypedElement selection dialog in:
org.eclipse.emf.facet.efacet.ui.dialogs.IETypedElementSelectionDialog
it can be opened from:
org.eclipse.emf.facet.efacet.ui.dialogs.IETypedElementSelectionDialogFactory
the unit tests for the ETypedElement selection dialog are in: org.eclipse.emf.facet.efacet.tests.internal.ETypedElementsSelectionDialogTests

The new dialog to choose an ETypedElement to determine what contents are allowed in a table is based on the generic ETypedElement selection dialog. Its interface is:
org.eclipse.emf.facet.widgets.table.ui.dialog.IAllowedContentsETypedElementSelectionDialog

Committed in revision 1582.

This bug is still missing unit tests for the new AllowedContentsETypedElementSelectionDialog. These tests will have to be written once this new dialog is integrated with the new table.
Comment 2 Nicolas Bros CLA 2012-02-22 09:47:13 EST 
I committed a refactoring of the ETypedElement selection dialog and accompanying unit tests in revision 1654, to extract a re-usable ETypedElement selection widget with a public API, and to open the dialog from a list of ETypedElements instead of relying on a viewer filter passed to the dialog. And I adapted the "allowed contents" ETypedElement selection dialog.
Comment 3 Nicolas Bros CLA 2012-04-23 05:39:00 EDT 
I adapted the tests to the dialog API changes in revision 2111.