Bug 370742 - No icons on the Debug view Layout action
Summary: No icons on the Debug view Layout action
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.8 M6   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2012-02-06 11:37 EST by Michael Rennie CLA
Modified: 2012-03-14 12:12 EDT (History)
1 user (show)

See Also:

Attachments
bp view with action icons (16.67 KB, image/png)
2012-02-06 11:37 EST, Michael Rennie CLA 		no flags Details
debug view with no icons (13.31 KB, image/png)
2012-02-06 11:37 EST, Michael Rennie CLA 		no flags Details
Tree mode icon (395 bytes, image/gif)
2012-02-22 12:07 EST, Pawel Piech CLA 		no flags Details
Breadcrumb mode icon. (209 bytes, image/gif)
2012-02-22 12:07 EST, Pawel Piech CLA 		no flags Details
Auto mode icon. (380 bytes, image/gif)
2012-02-22 12:08 EST, Pawel Piech CLA 		no flags Details
screen shot (11.24 KB, image/png)
2012-02-22 14:06 EST, Michael Rennie CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2012-02-06 11:37:10 EST 
Created attachment 210601 [details]
bp view with action icons

Version: 4.2.0
Build id: I20120126-1300

Unlike the rest of the debug views, the Debug View > Layout actions do not have the associated icons on the actions.

See the attached screen shots
Comment 1 Michael Rennie CLA 2012-02-06 11:37:58 EST 
Created attachment 210602 [details]
debug view with no icons
Comment 2 Michael Rennie CLA 2012-02-06 11:43:10 EST 
The problem is that we do not set the image descriptor in DebugViewModeAction
Comment 3 Pawel Piech CLA 2012-02-22 12:07:16 EST 
Created attachment 211426 [details]
Tree mode icon
Comment 4 Pawel Piech CLA 2012-02-22 12:07:37 EST 
Created attachment 211427 [details]
Breadcrumb mode icon.
Comment 5 Pawel Piech CLA 2012-02-22 12:08:28 EST 
Created attachment 211428 [details]
Auto mode icon.

Given my limited artistic abilities.  Here are the icons I hacked up for the debug view layout menu.  Mike is this what you had in mind?
Comment 6 Michael Rennie CLA 2012-02-22 14:06:36 EST 
Created attachment 211440 [details]
screen shot

looks good to me.

Since I have the changes in my workspace do you want me to push it for you?
Comment 7 Pawel Piech CLA 2012-02-22 14:24:17 EST 
Sure, I had only drawn the icons so far, but if you hooked them up already then go ahead :-)
Comment 8 Pawel Piech CLA 2012-02-22 14:25:28 EST 
(In reply to comment #6)
> Created attachment 211440 [details]
> screen shot
Oh I see, you just re-used the detail pane icons instead of the ones I attached.  That's fine by me too.
Comment 10 Michael Rennie CLA 2012-03-14 12:12:56 EDT 
Verified in:
Version: 4.2.0
Build id: I20120313-0610