Community
Participate
Working Groups
Once Ant 1.8.3 is released we will put it in Orbit (bug 370356) and then it should be released to the Platform's builds.
Created attachment 212054 [details] Ant 1.8.3 plugin zip I have packaged the new bits into this plugin. There are some files which I don't know if we should take. Here are some of them. Mike, Please look at these and let me know your thoughts on this? 1. From 1.8.3, I just copied bin, etc, lib, LICENSE.TXT and NOTICE.TXT. I didn't copy manual, fetch.xml, get-m2.xml, INSTALL.txt, KEYS.txt, README.txt and WHATSNEW.txt as the previous versions of this file were not there. 2. The lib directory has pom files. Do we need to include them? I have removed them. 3. In the directory about_files, I didn't get the files ASL-LICENSE-2.0.txt, DOM-LICENSE.html and SAX-LICENSE.html. 4. Where to get about.html file from?
Mike, Can you please look at my questions in comment 1 and the zip and see what else need to be done? Thanks.
(In reply to comment #1) > > 1. From 1.8.3, I just copied bin, etc, lib, LICENSE.TXT and NOTICE.TXT. > I didn't copy manual, fetch.xml, get-m2.xml, INSTALL.txt, KEYS.txt, README.txt > and WHATSNEW.txt as the previous versions of this file were not there. > This is fine. > 2. The lib directory has pom files. Do we need to include them? I have removed > them. The pom files are used by Apache for building Ant, they can stay removed. > 3. In the directory about_files, I didn't get the files ASL-LICENSE-2.0.txt, > DOM-LICENSE.html and SAX-LICENSE.html. You can get them from: http://apache.org/licenses/LICENSE-2.0 <- this is the ASL-LICENSE.txt http://www.saxproject.org/copying.html <- this is the SAX 'license' http://www.w3.org/Consortium/Legal/2002/copyright-software-20021231 <- the DOM license > 4. Where to get about.html file from? We created that ourselves and you can just copy it over. Just make sure to update any of the links in it if you change the names of anything in the /about_files directory.
(In reply to comment #3) Thanks Mike. > > 3. In the directory about_files, I didn't get the files ASL-LICENSE-2.0.txt, > > DOM-LICENSE.html and SAX-LICENSE.html. > > You can get them from: > > http://apache.org/licenses/LICENSE-2.0 <- this is the ASL-LICENSE.txt > http://www.saxproject.org/copying.html <- this is the SAX 'license' > http://www.w3.org/Consortium/Legal/2002/copyright-software-20021231 <- the DOM > license I don't see anything modified. So, leaving them around. > > 4. Where to get about.html file from? > > We created that ourselves and you can just copy it over. Just make sure to > update any of the links in it if you change the names of anything in the > /about_files directory. I had to just update the Ant version. Everything looks good.
Created attachment 212118 [details] Ant 1.8.3 Eclipse plugin zip Updated the zip as for comment 3.
Created attachment 212269 [details] Ant 1.8.3 bundle Here is a new version of Ant 1.8.3 that can be exported into your host for testing. So far all of the JUnit tests pass (with the patch applied I will post here) and smoke testing has not revealed any issues. I have no yet run the performance tests.
Created attachment 212270 [details] Ant tests patch
The bundle I posted has some shape changes - rather than having to mass copy / paste source into differing dirs per library I updated the classpath + build.properties to build the source bundle with only one source root rather than 15 or so. The benefit of this is three-fold: 1. there are less source roots for the platform to work with when debugging - should make source lookup in the Apache classes a bit faster 2. the bundle can now be built like a 'normal' Eclipse bundle with source 3. when creating new versions of org.apache.ant in the future you only have to grab the source and dump it in the 'libsrc' dir and you are done, rather than the labour-intensive way of doing it now - creating a bunch of dirs per library, copying different source to different dirs, etc, etc
Satyam, Curtis and I are testing the new Ant bundle installed in our host 4.2 installations, can I get you to test it in 3.8? To test: 1. import org.apache.ant into your workspace 2. context menu > Export > Deployable plugins and fragments 3. select install into host 4. Options tab > 'Export Source' set to "generate source bundles" 5. apply tests patch
(In reply to comment #9) Thanks Mike for the detailed instructions. I was able to install it and able to run. All tests look good. I didn't see any issues while testing, except for the source code as there is no source attachment. Will it be different in the real installation?
(In reply to comment #10) > (In reply to comment #9) > Thanks Mike for the detailed instructions. I was able to install it and able to > run. All tests look good. I didn't see any issues while testing, except for the > source code as there is no source attachment. Will it be different in the real > installation? This will be fine in a real installation. PDE's install into host action doesn't modify the source features when creating the feature patch. I opened bug 373967 for this.
Ant 1.8.3 fixes a bug where JUnitReport fails under Java 7 when Ant is run in embedded environments such as Eclispe: https://issues.apache.org/bugzilla/show_bug.cgi?id=51668 So I'm hoping the inclusion of Ant 1.8.3 in Eclipse Indigo will be soon.
Created attachment 212495 [details] pre-build Ant binary bundle
Created attachment 212496 [details] pre-built Ant source bundle
The test pass for M6 is today. We should not risk to destabilize the builds and the drops and consume this with the first M7 I-build.
(In reply to comment #12) > So I'm hoping the inclusion of Ant 1.8.3 in Eclipse Indigo will be soon. I guess you meant 'Juno', as there won't be any further Indigo (i.e. 3.7.x) builds.
(In reply to comment #15) > The test pass for M6 is today. We should not risk to destabilize the builds and > the drops and consume this with the first M7 I-build. I agree completely, I just did not get around to moving the milestone yet.
Test build running now maps http://git.eclipse.org/c/platform/eclipse.platform.releng.maps.git/commit/?id=a673d9680bc9eb54f47750ae97cc17037bf64053 sdk feature http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=68be100d413a149be6b7e67fa1eed4792faf97d5 doc http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=73ef08da7cb78082a58b2fe8ffc002d4b6b14ebf David, the orbit.map file will have to be updated when we have a stable Orbit build that includes Ant 1.8.3
test build successful, released to integration
(In reply to comment #19) > test build successful, released to integration Except for the Ant tests patch, which I pushed here: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b3981a7fcd79832097b50206a1544b7a29d41363
(In reply to comment #20) > (In reply to comment #19) > > test build successful, released to integration > > Except for the Ant tests patch, which I pushed here: > > http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b3981a7fcd79832097b50206a1544b7a29d41363 One more failure in the I/N-build (I20120320-1400): testAntHome Failure Incorrect message. Should end with org.apache.ant. Message: [echo] C:\buildtest\N20120320-2000\eclipse-testing\test-eclipse\eclipse\plugins\org.apache.ant_1.8.3.v20120316-1400 junit.framework.AssertionFailedError: Incorrect message. Should end with org.apache.ant. Message: [echo] C:\buildtest\N20120320-2000\eclipse-testing\test-eclipse\eclipse\plugins\org.apache.ant_1.8.3.v20120316-1400 at org.eclipse.ant.tests.ui.separateVM.SeparateVMTests.testAntHome(SeparateVMTests.java:223) at org.eclipse.ant.tests.ui.AbstractAntUIBuildTest.access$0(AbstractAntUIBuildTest.java:1) at org.eclipse.ant.tests.ui.AbstractAntUIBuildTest$1.run(AbstractAntUIBuildTest.java:44) at java.lang.Thread.run(Thread.java:722)
(In reply to comment #21) > One more failure in the I/N-build (I20120320-1400): > > testAntHome fixed in: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=8eec0a6e1a22bff56b6e457a756291246ab1e321
Marking as fixed, Ant 1.8.3 is in builds > 21/03/2012 and no issues have been found so far. Any problems should be opened in their own bugs.
Verified in 3.8-I20120429-2000 and 4.2-I20120429-1800.
