Bug 368851 - Help command list inaccessible
Summary: Help command list inaccessible
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Susan McCourt CLA
QA Contact: Carolyn MacLeod CLA
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 365361
  Show dependency tree
 
Reported: 2012-01-17 11:58 EST by Max Li CLA
Modified: 2012-02-10 13:05 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Li CLA 2012-01-17 11:58:58 EST 
Build Identifier: 0.3

The help command list (that is brought up by pressing Ctrl+Shift+L) cannot be read by a screen reader. So a user who needs a screen reader would be unable to read the contents of the popup.

Reproducible: Always
Comment 1 Max Li CLA 2012-01-24 09:18:19 EST 
I have fixed this bug in the following repository in the accessibility branch.
https://github.com/max-li/orion.client.git
Comment 2 Felipe Heidrich CLA 2012-01-24 10:19:28 EST 
Hey Max, this time I not able to find the commit in https://github.com/max-li/orion.client/commits/accessibility
Comment 4 Susan McCourt CLA 2012-01-24 11:22:29 EST 
I'm working in commands today so I can commit this.
Thanks, Max!
Comment 5 Susan McCourt CLA 2012-01-24 11:23:10 EST 
(changing ownership back, somehow I fumbled those "set default" checkboxes)
Comment 6 Susan McCourt CLA 2012-01-24 17:31:23 EST 
Hi, Max.  The commit looks reasonable but I'm still not sure how to verify it fixes the problem.  

From the navigator, if I invoke the dialog (using '?') and start pressing the tab key to visit various things on the page, I still never get to that popup.  I guess I assumed I could observe the fix by traversing to the dialog (and then assuming a screenreader would get it right).  

(tested from the navigator because from the editor I could never keyboard navigate out of the editor anyway so I didn't know how to verify it on that page.)
Comment 7 Susan McCourt CLA 2012-01-24 19:15:02 EST 
I'm guessing based on the other fixes that you need a tab order in addition to a role.
Comment 8 Max Li CLA 2012-01-25 10:22:30 EST 
By setting the aria-live property, the screen reader should automatically start reading the contents of the help box (and it does do that from my own testing). So the popup does not need to be in the tab order.

(This works fine in the editor. JAWS has its own keybinding for ? so I can't actually bring the help up outside of the editor. I figure this will be dealt with in bug 349602.)
Comment 9 Susan McCourt CLA 2012-01-26 17:25:50 EST 
Thanks for the explanation...
Merged the commit in because I've been messing around in these files.
Could you retest as a sanity check that I didn't mess it up?  Thanks!
Comment 10 Max Li CLA 2012-01-30 09:09:38 EST 
(In reply to comment #9)
> Thanks for the explanation...
> Merged the commit in because I've been messing around in these files.
> Could you retest as a sanity check that I didn't mess it up?  Thanks!

I've retested and everything looks good.