Bug 368822 - remove osgi tests which require org.eclipse.core.runtime.compatibility.auth
Summary: remove osgi tests which require org.eclipse.core.runtime.compatibility.auth
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 355430
  Show dependency tree
 
Reported: 2012-01-17 08:41 EST by Kim Moir CLA
Modified: 2012-01-17 15:07 EST (History)
2 users (show)

See Also:

Attachments
patch (801 bytes, patch)
2012-01-17 09:24 EST, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Moir CLA 2012-01-17 08:41:12 EST 
I've been running test builds where the 4.2 build is primary and we run all our tests against it.  For the osgi tests, there's a failure.  It seems to be the tests are looking for org.eclipse.core.runtime.compatibility.auth.  John has said that this bundle shouldn't exist in 4.2 stream builds. See 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=355430#c9

Failed to invoke suite():junit.framework.AssertionFailedError: 0.0.1.org.eclipse.core.runtime.compatibility.auth

org.eclipse.test.EclipseTestRunner$TestFailedException: Failed to invoke suite():junit.framework.AssertionFailedError: 0.0.1.org.eclipse.core.runtime.compatibility.auth
at org.eclipse.test.EclipseTestRunner.runFailed(EclipseTestRunner.java:430)
at org.eclipse.test.EclipseTestRunner.getTest(EclipseTestRunner.java:417)
at org.eclipse.test.EclipseTestRunner.<init>(EclipseTestRunner.java:348)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:257)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
at org.eclipse.equinox.launcher.Main.run(Main.java:1433)
at org.eclipse.equinox.launcher.Main.main(Main.java:1409)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 1 Thomas Watson CLA 2012-01-17 09:08:28 EST 
I am guessing this is because the constant org.eclipse.core.tests.session.ConfigurationSessionTestSuite.MINIMAL_BUNDLE_SET lists org.eclipse.core.runtime.compatibility.auth but I am not sure.
Comment 2 Thomas Watson CLA 2012-01-17 09:23:54 EST 
When I remove org.eclipse.core.runtime.compatibility.auth from the list MINIMAL_BUNDLE_SET I can run the osgi tests without the org.eclipse.core.runtime.compatibility.auth bundle.

I suspect org.eclipse.core.tests.internal.runtime.PlatformURLSessionTest test should also fail because of the same issue.
Comment 3 Thomas Watson CLA 2012-01-17 09:24:36 EST 
Created attachment 209621 [details]
patch
Comment 4 John Arthorne CLA 2012-01-17 14:38:11 EST 
Thanks Tom, I'll verify and fix up the other one.
Comment 5 John Arthorne CLA 2012-01-17 15:07:21 EST 
I released Tom's fix after verifying all tests pass with runtime.compatibility.auth bundle not present. Thanks again Tom.