Bug 367806 - Back-port script resolution API and crossfire updates
Summary: Back-port script resolution API and crossfire updates
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.2.5P   Edit
Assignee: Michael Rennie CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords: api, noteworthy
Depends on: 356600 359093 359451 361315 361947 362841 363395 365343
Blocks:
  Show dependency tree
 
Reported: 2012-01-03 19:45 EST by Michael Rennie CLA
Modified: 2012-03-27 11:46 EDT (History)
4 users (show)

See Also:
thatnitind: review+

Attachments
backport (276.26 KB, patch)
2012-01-03 19:46 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2012-01-03 19:45:14 EST 
An adopter has requested that we provide the new script resolution API (bug 361315) and the accompanying crossfire bug fixes in 3.2.5+.

The following is a listing of the bugs that comprise the minimum change set for the back port of the requested support.

Bug 365343 - Use new IScriptResolver API during source lookup 
 - risk: use of new API from bug 361315
Bug 363395 - Firebug console messages do not appear in Eclipse any longer 
 - risk: none
Bug 362841 - Show Stack Frame label as Script Name , Function Name and Line Number 
 - risk: none
Bug 361947 - Boolean arguments are not checked for valid state 
 - risk: none
Bug 361315 - Crossfire Remote Attach does not sync breakpoints from Eclipse to Firebug when setting a project or WS as the source. 
 - risk: new API
Bug 359451 - ISourceLookupDirector does not make honor to new ISourceLocator added programatically 
 - risk: none
Bug 356600 - [crossfire] Add support for creating error problems in Eclipse from FB / Crossfire 
 - risk: none
Bug 359093 - Abort a pending step if no StepEvent is received prior to a SuspendEvent
 - risk: none

The given set basically comprises all of the work done since the last back-port from HEAD (bug 353225), which is why I recommend we simply do another back-port from HEAD, ensuring we get all of the other small fixes tagged as [nobug], etc.

The attached patch provides the suggested back-port and applies to R3_2_maintenance for JSDT.
Comment 1 Michael Rennie CLA 2012-01-03 19:46:48 EST 
Created attachment 208974 [details]
backport
Comment 2 Michael Rennie CLA 2012-03-27 11:46:24 EDT 
looks like this found its way to the 3.2.5 patch branch.

Marking fixed